From: "Michael Chan" <mchan@broadcom.com>
To: "Ben Hutchings" <bhutchings@solarflare.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/5] bnx2: Read firmware version from VPD.
Date: Thu, 3 Dec 2009 13:43:48 -0800 [thread overview]
Message-ID: <1259876628.8991.7.camel@HP1> (raw)
In-Reply-To: <1259871433.2780.42.camel@achroite.uk.solarflarecom.com>
On Thu, 2009-12-03 at 12:17 -0800, Ben Hutchings wrote:
> > + for (i = 0; i < 128; i += 4) {
> > + data[i] = data[i + 131];
> > + data[i + 1] = data[i + 130];
> > + data[i + 2] = data[i + 129];
> > + data[i + 3] = data[i + 128];
> > + }
>
> Is this correct for both big-endian and little-endian architectures?
Yes, the nvram function returns data in a byte-stream that is the same
in little or big endian.
> Perhaps these VPD tag values should go in pci_regs.h.
How about we do this later and convert other drivers at the same time?
I will send out a fixup patch shortly incorporating all your other
suggestions. Thanks.
next prev parent reply other threads:[~2009-12-03 21:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 19:46 [PATCH 1/5] bnx2: Protect tx timeout reset with rtnl_lock() Michael Chan
2009-12-03 19:46 ` [PATCH 2/5] bnx2: Dump some state during tx timeout Michael Chan
2009-12-03 21:07 ` David Miller
2009-12-03 19:46 ` [PATCH 3/5] bnx2: Print warning when unable to allocate the full SKB/page ring Michael Chan
2009-12-03 21:08 ` David Miller
2009-12-03 21:49 ` Michael Chan
2009-12-03 22:05 ` David Miller
2009-12-03 19:46 ` [PATCH 4/5] bnx2: Read firmware version from VPD Michael Chan
2009-12-03 20:17 ` Ben Hutchings
2009-12-03 21:43 ` Michael Chan [this message]
2009-12-03 21:08 ` David Miller
2009-12-03 19:46 ` [PATCH 5/5] bnx2: Update version to 2.0.3 Michael Chan
2009-12-03 21:08 ` David Miller
2009-12-03 21:07 ` [PATCH 1/5] bnx2: Protect tx timeout reset with rtnl_lock() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259876628.8991.7.camel@HP1 \
--to=mchan@broadcom.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).