netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: RFC: how to control device specific features. sysfs or mod param?
Date: Sat, 05 Dec 2009 02:29:39 -0800	[thread overview]
Message-ID: <1260008979.3565.25.camel@localhost> (raw)
In-Reply-To: <20091205.022540.250826631.davem@davemloft.net>

On Sat, 2009-12-05 at 02:25 -0800, David Miller wrote:
> From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Date: Sat, 05 Dec 2009 02:22:53 -0800
> 
> > Yes, I looked at either ethtool or extending any of the existing
> > rtnetlink interfaces.  But my problem with those is this setting is very
> > specific to my hardware, and I'm not sure anyone else could benefit from
> > this.
> > 
> > I could try and make it as generic as possible, say pass a 32 or 64-bit
> > generic bitfield to a driver through an ethtool operation, and each
> > driver would apply some secret sauce based on the bitfield?
> 
> We support device specific statistics in a nice way in ethtool, why
> don't we do something similar for device specific settings?
> 
> A variable length array of names (strings) and values.
> 
> This is pretty straightforward for what %99.9999 of uses will be,
> boolean enables.  If we make the value type a u32 we can handle pretty
> much all the other cases as well.

That does make sense.  I'll try and put something together to make this
work.

Thanks Dave,
-PJ


      reply	other threads:[~2009-12-05 10:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-05  9:55 RFC: how to control device specific features. sysfs or mod param? Peter P Waskiewicz Jr
2009-12-05 10:13 ` David Miller
2009-12-05 10:22   ` Peter P Waskiewicz Jr
2009-12-05 10:25     ` David Miller
2009-12-05 10:29       ` Peter P Waskiewicz Jr [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260008979.3565.25.camel@localhost \
    --to=peter.p.waskiewicz.jr@intel.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).