netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gurucharan Shetty <gshetty@riverbed.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Arthur Jones <Arthur.Jones@riverbed.com>,
	Gurucharan Shetty <gshetty@riverbed.com>
Subject: Re: [PATCH] ixgbe: allow tx of pre-formatted vlan tagged packets
Date: Mon, 7 Dec 2009 12:02:08 -0800	[thread overview]
Message-ID: <1260216128.4226.18.camel@gshetty> (raw)
In-Reply-To: <9929d2390912041345g4557770bh1467db58b8ade572@mail.gmail.com>

On Fri, 2009-12-04 at 13:45 -0800, Jeff Kirsher wrote:
> On Fri, Dec 4, 2009 at 13:12, Gurucharan Shetty <gshetty@riverbed.com> wrote:
> > ixgbe: allow tx of pre-formatted vlan tagged packets
> >
> > When the 82598 is fed 802.1q packets, it chokes with
> > an error of the form:
> >
> > ixgbe: eth0: ixgbe_tx_csum: partial checksum but proto=81!
> >
> > As the logic there was not smart enough to look into
> > the vlan header to pick out the encapsulated protocol.
> >
> > There are times when we'd like to send these packets
> > out without having to configure a vlan on the interface.
> > Here we check for the vlan tag and allow the packet to
> > go out with the correct hardware checksum.
> >
> > This patch is a clone of a previously submitted patch by
> > Arthur Jones <ajones@riverbed.com> for igb (Commit -
> > fa4a7ef36ec834fee1719636b30d2f28f4cb0166).
> >
> > Signed-off-by: Gurucharan Shetty <gshetty@riverbed.com>
> > Signed-off-by: Arthur Jones <ajones@riverbed.com>
> >
> 
> Thanks, I have added the patch to my queue for testing.  After
> successful testing, I will push to Dave/netdev.
> 
Oops. I messed up with the patch that I sent. It missed a line.
I am re-sending the patch in the next message. Sorry for the
inconvenience.

Thanks,
Gurucharan Shetty


  reply	other threads:[~2009-12-07 20:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04 21:12 [PATCH] ixgbe: allow tx of pre-formatted vlan tagged packets Gurucharan Shetty
2009-12-04 21:45 ` Jeff Kirsher
2009-12-07 20:02   ` Gurucharan Shetty [this message]
2009-12-07 20:04     ` Gurucharan Shetty
2009-12-07 20:50       ` Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260216128.4226.18.camel@gshetty \
    --to=gshetty@riverbed.com \
    --cc=Arthur.Jones@riverbed.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).