From: David Dillow <dave@thedillows.org>
To: "François romieu" <romieu@zoreil.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
netdev@vger.kernel.org, davem@davemloft.net,
eric.dumazet@gmail.com, nhorman@redhat.com
Subject: Re: [PATCH RFC] r8169: straighten out overlength frame detection
Date: Mon, 28 Dec 2009 19:24:51 -0500 [thread overview]
Message-ID: <1262046291.8998.6.camel@obelisk.thedillows.org> (raw)
In-Reply-To: <20091228213114.GA24285@zoreil.com>
On Mon, 2009-12-28 at 22:31 +0100, François romieu wrote:
> (I'm back)
>
> The Mon, Dec 28, 2009 at 02:50:53PM -0500, Neil Horman wrote :
> [...]
> I doubt that we will be able to allocate that much memory reliably for long.
>
> I'd rather go for static buffers + copy (+ src mac address of our new friend).
The driver doesn't support fragmented receives, but it seems like the HW
does -- is this known to work on the different revisions? Or
alternatively, is it known to be broken on any of them? It seems like it
would be preferable to implement this and use RxMaxSize to tell the NIC
how big the allocated buffer fragments are.
Or I'm misreading the capabilities of the NIC?
In any event, I'm probably not going to have time to write/test it on
the HW I have anytime soon, so perhaps the static buffers/copy is the
safest option for now, albeit non-optimal.
Dave
next prev parent reply other threads:[~2009-12-29 0:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-28 19:48 [PATCH RFC] r8169: straighten out overlength frame detection Neil Horman
2009-12-28 19:50 ` Neil Horman
2009-12-28 21:31 ` François romieu
2009-12-28 23:49 ` Neil Horman
2009-12-29 0:24 ` David Dillow [this message]
2009-12-29 1:20 ` Neil Horman
2009-12-29 0:51 ` Ben Hutchings
2009-12-29 1:16 ` Neil Horman
2009-12-29 1:29 ` Ben Hutchings
2009-12-29 15:35 ` Neil Horman
2010-01-05 13:57 ` [PATCH RFC] r8169: straighten out overlength frame detection (v3) Neil Horman
2010-01-05 15:15 ` Eric Dumazet
2010-01-05 20:40 ` David Miller
2010-01-05 21:38 ` Neil Horman
2010-01-05 21:45 ` David Miller
2010-01-05 22:04 ` Neil Horman
2010-01-07 1:01 ` Francois Romieu
2010-01-07 1:15 ` David Miller
2010-01-08 23:48 ` Francois Romieu
2010-01-09 0:02 ` David Miller
2010-01-10 1:57 ` Ben Hutchings
2010-01-10 23:50 ` Francois Romieu
2010-01-11 6:45 ` David Miller
2010-01-12 0:16 ` Francois Romieu
2010-01-12 6:24 ` David Miller
2010-01-26 22:07 ` Brandon Philips
2010-01-30 21:50 ` Neil Horman
2010-02-18 19:37 ` Brandon Philips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262046291.8998.6.camel@obelisk.thedillows.org \
--to=dave@thedillows.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=nhorman@tuxdriver.com \
--cc=romieu@zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).