From: Joe Perches <joe@perches.com>
To: "Michał Mirosław" <mirqus@gmail.com>
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
David Miller <davem@davemloft.net>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] lib/vsprintf.c: Add %pMF to format FDDI bit reversed MAC addresses
Date: Thu, 07 Jan 2010 13:36:15 -0800 [thread overview]
Message-ID: <1262900175.10429.75.camel@Joe-Laptop.home> (raw)
In-Reply-To: <e2d7436a1001071318l75750b29uece2a61884538d5b@mail.gmail.com>
On Thu, 2010-01-07 at 22:18 +0100, Michał Mirosław wrote:
> Something like the following might be smaller and faster - no
> functions and their calls
> int rev = (fmt[1] == 'F');
> p = pack_hex_byte(p, rev ? bitrev8(addr[i]) : addr[i]);
Right, better. Just 6 bytes (x86). Resubmitting.
next prev parent reply other threads:[~2010-01-07 21:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BD79186B4FD85F4B8E60E381CAEE19090208954A@mi8nycmail19.Mi8.com>
2010-01-07 18:23 ` [PATCH] lib/vsprintf.c: Add %pMF to format FDDI bit reversed MAC addresses Joe Perches
2010-01-07 20:42 ` Maciej W. Rozycki
2010-01-07 21:13 ` Michał Mirosław
2010-01-07 22:09 ` David Miller
2010-01-08 0:08 ` Simon Horman
2010-01-08 1:51 ` Joe Perches
2010-01-08 2:48 ` Simon Horman
2010-01-07 21:18 ` Michał Mirosław
2010-01-07 21:36 ` Joe Perches [this message]
2010-01-07 21:37 ` [PATCH V2] " Joe Perches
2010-01-07 22:11 ` David Miller
2010-01-07 21:43 ` [PATCH V3] " Joe Perches
2010-01-08 0:58 ` David Miller
2010-01-19 10:57 ` [PATCH] " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262900175.10429.75.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).