From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Subject: Re: [PATCH] lib/vsprintf.c: Add %pMF to format FDDI bit reversed
 MAC addresses
Date: Thu, 07 Jan 2010 17:51:48 -0800
Message-ID: <1262915508.10429.99.camel@Joe-Laptop.home>
References: <BD79186B4FD85F4B8E60E381CAEE19090208954A@mi8nycmail19.Mi8.com>
	 <1262888625.10429.23.camel@Joe-Laptop.home>
	 <alpine.LFD.2.00.1001072037170.13474@eddie.linux-mips.org>
	 <20100107.140942.135976087.davem@davemloft.net>
	 <20100108000843.GI2436@verge.net.au>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>, macro@linux-mips.org,
	hartleys@visionengravers.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
To: Simon Horman <horms@verge.net.au>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1752813Ab0AHBvv@vger.kernel.org>
In-Reply-To: <20100108000843.GI2436@verge.net.au>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Fri, 2010-01-08 at 11:08 +1100, Simon Horman wrote:
> In the vein of this, would it be worth adding some modifier to %i4 to
> print addresses for ftp helpers? That is, %u,%u,%u,%u. I think
> there are currently two users of that format string after Joe's latest
> round of updates.

I think not.  I think the comma separated uses
are unusual enough to not support in lib/vsprintf.

I did submit a patch to support format strings
for le32 and u32 ipv4 addresses.

> The users are net/netfilter/ipvs/ip_vs_ftp.c and
> net/ipv4/netfilter/nf_nat_ftp.c. Prior to Joe's latest
> changes ip_vs_ftp.c used %d,%d,%d,%d.

I submitted a couple of patches that should help.

o eventually remove NIPQUAD and NIPQUAD_FMT
o consolidate the 2 netfilter "%u,%u,%u,%u" uses
  to a single function