From: Matt Mackall <mpm@selenic.com>
To: Daniel Borkmann <danborkmann@googlemail.com>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, jmoyer@redhat.com,
netdev@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [PATCH] netpoll: allow execution of multiple rx_hooks per interface
Date: Mon, 11 Jan 2010 17:21:48 -0600 [thread overview]
Message-ID: <1263252108.29868.4774.camel@calx> (raw)
In-Reply-To: <4B467A4D.9070708@gmail.com>
On Fri, 2010-01-08 at 01:20 +0100, Daniel Borkmann wrote:
> Daniel Borkmann wrote:
> > David Miller wrote:
> >> From: Matt Mackall <mpm@selenic.com>
> >> Date: Wed, 06 Jan 2010 21:54:05 -0600
> >>
> >>> Please inline patches so they can be reviewed easily in reply.
> >>>
> >>>
> >>> - struct netpoll *np = npi->rx_np;
> >>> + struct netpoll **np = &npi->rx_np;
> >>>
> >>> - if (!np)
> >>> + if (!(*np))
> >>>
> >>> This makes everything horrible. Can you avoid the double indirection?
> >>> Using a list head might be a good answer.
> >>>
> >> Agreed on all counts.
> >>
> >
> > Agreed on the double indirection, I'll fix it.
> >
> > I've already considered the list_head structure, but then I was the opinion
> > that a double linked list might not be necessary for this, so I did it that
> > way ... (compare: kernel notifier by Alan Cox). If you insist on that I'll
> > fix it of course ;)
>
> So, here's the list head implementation. Tested on both of my machines with several
> rx_hook clients.
Looks pretty good. Dave?
Acked-by: Matt Mackall <mpm@selenic.com>
--
http://selenic.com : development and support for Mercurial and Linux
next prev parent reply other threads:[~2010-01-11 23:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 20:54 [PATCH] netpoll: allow execution of multiple rx_hooks per interface Daniel Borkmann
2010-01-07 3:54 ` Matt Mackall
2010-01-07 9:02 ` David Miller
2010-01-07 19:06 ` Daniel Borkmann
2010-01-08 0:20 ` Daniel Borkmann
2010-01-11 23:21 ` Matt Mackall [this message]
2010-01-11 23:59 ` David Miller
2010-01-12 0:03 ` Matt Mackall
2010-01-12 0:09 ` Daniel Borkmann
2010-01-13 0:27 ` Daniel Borkmann
2010-01-13 13:57 ` Jeff Moyer
2010-01-13 16:53 ` Daniel Borkmann
2010-01-14 4:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263252108.29868.4774.camel@calx \
--to=mpm@selenic.com \
--cc=danborkmann@googlemail.com \
--cc=davem@davemloft.net \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).