From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: roel.kluin@gmail.com, netdev@vger.kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
sivakumar.subramani@neterion.com, ram.vepa@neterion.com,
santosh.rastapur@neterion.com, sreenivasa.honnur@neterion.com,
anil.murthy@neterion.com
Subject: Re: [PATCH] S2io: two branches the same in wait_for_cmd_complete()
Date: Sun, 17 Jan 2010 19:58:32 -0800 [thread overview]
Message-ID: <1263787112.26846.73.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20100117.191359.190417865.davem@davemloft.net>
On Sun, 2010-01-17 at 19:13 -0800, David Miller wrote:
> From: Roel Kluin <roel.kluin@gmail.com>
> Date: Sun, 17 Jan 2010 16:10:04 +0100
> > Regardless of the bit_state, the branches execute the same code.
> > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > ---
> > drivers/net/s2io.c | 13 +++----------
> > 1 files changed, 3 insertions(+), 10 deletions(-)
> > Maybe something else was intended?
> > this was introduced in commit 9fc93a41a1ad11
> If you know the guilty commit, at least do the author(s) of commit
> and/or the driver maintainer(s) the courtesy of CC:'ing them on
> patches like this.
One way to do that is to use:
$ ./scripts/get_maintainer.pl --git-blame <patch>
next prev parent reply other threads:[~2010-01-18 3:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 15:10 [PATCH] S2io: two branches the same in wait_for_cmd_complete() Roel Kluin
2010-01-18 3:13 ` David Miller
2010-01-18 3:58 ` Joe Perches [this message]
2010-01-18 7:20 ` Ramkrishna Vepa
2010-01-19 9:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263787112.26846.73.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=anil.murthy@neterion.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ram.vepa@neterion.com \
--cc=roel.kluin@gmail.com \
--cc=santosh.rastapur@neterion.com \
--cc=sivakumar.subramani@neterion.com \
--cc=sreenivasa.honnur@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).