From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Holtmann Subject: RE: [PATCH net-next-2.6 03/13] net-caif: add CAIF generic protocol stack header files Date: Fri, 22 Jan 2010 11:24:53 +0100 Message-ID: <1264155893.3469.46.camel@violet> References: <1264028130-14364-1-git-send-email-sjur.brandeland@stericsson.com> <1264028130-14364-4-git-send-email-sjur.brandeland@stericsson.com> <1264152497.3469.20.camel@violet> <61D8D34BB13CFE408D154529C120E07903232092@eseldmw101.eemea.ericsson.se> <1264155124.3469.39.camel@violet> <61D8D34BB13CFE408D154529C120E0790323209A@eseldmw101.eemea.ericsson.se> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, stefano.babic@babic.homelinux.org, randy.dunlap@oracle.com To: Sjur =?ISO-8859-1?Q?Br=E6ndeland?= Return-path: Received: from senator.holtmann.net ([87.106.208.187]:53637 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754532Ab0AVKXw (ORCPT ); Fri, 22 Jan 2010 05:23:52 -0500 In-Reply-To: <61D8D34BB13CFE408D154529C120E0790323209A@eseldmw101.eemea.ericsson.se> Sender: netdev-owner@vger.kernel.org List-ID: Hi Sjur, > >>>> Add include files for the generic CAIF protocol stack. This layer > >>>> is somewhat generic in order to be able to use and test it outside > >>>> the Linux Kernel. > >>>> > >>>> caif_layer.h - Defines the structure of the CAIF protocol layers > >>>> cfcnfg.h - CAIF Configuration Module for services and link > >>>> layers cfctrl.h - CAIF Control Protocol Layer > >>>> cffrml.h - CAIF Framing Layer > >>>> cfglue.h - CAIF Glue Layer for allocation, logging etc > >>>> cflist.h - CAIF List implementation > >>>> cfmuxl.h - CAIF Muxing Layer > >>>> cfpkt.h - CAIF Packet layer (skb helper functions) > >>>> cfserl.h - CAIF Serial Layer > >>>> cfsrvl.h - CAIF Service Layer > >>> > >>> is it really needed to keep the "generic" piece in the path here. I > >>> would prefer if we get rid of it. > >> > >> Are you suggesting to move this files to include/net/caif? > >> I can do this in the next patch set. > >> The reason for the term "generic" is that this that the core part of > >> the CAIF stack originally was designed to be OS independent. > > > > I understand where you are coming from, but for the Linux > > implementation it doesn't really sound like a good idea. Especially > > with the move to a socket based implementation you really diverge > > here already. > > > > Also the cfglue.[ch] pieces are really controversial. I would prefer > > not to have OS glue code here. Just use native lists, locks etc. It > > makes the code a lot easier to review for all the Linux people ;) > > > > Yes, I was kind of expecting this feedback. The problem is that I have > to ditch more than 50 unit tests that I have in user space. They are > very handy when debugging protocol problems. what about having a script for that. Something that takes the "clean" kernel code. Does some sed etc. magic and still lets you run your unit tests in userspace. Or what a about a kernel module that does these unit tests in kernel space. I really don't know how feasible this is, but think about it. Regards Marcel