netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH 00/21] net/atm neatening cleanups
Date: Tue, 26 Jan 2010 21:11:49 -0800	[thread overview]
Message-ID: <1264569109.14552.3.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20100126.205757.101473582.davem@davemloft.net>

On Tue, 2010-01-26 at 20:57 -0800, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Tue, 26 Jan 2010 13:39:59 -0800
> > Miscellaneous cleanups to net/atm
> All looks good.

Unfortunately, appearances aren't necessarily trustworthy.
5/21 is missing a close parenthesis.

+	print_hex_dump(KERN_DEBUG, "br2684: skb: ", DUMP_OFFSET,
+	               16, 1, skb->data, min(NUM2PRINT, skb->len, true);
 #endif

should be:

+	print_hex_dump(KERN_DEBUG, "br2684: skb: ", DUMP_OFFSET,
+	               16, 1, skb->data, min(NUM2PRINT, skb->len), true);
 #endif

Want an updated 5/21 or another patch?


  reply	other threads:[~2010-01-27  5:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-26 21:39 [net-next PATCH 00/21] net/atm neatening cleanups Joe Perches
2010-01-26 21:40 ` [PATCH 01/21] net/atm: Convert printk to pr_<level> Joe Perches
2010-01-26 21:40 ` [PATCH 02/21] net/atm/addr.c: Convert include <asm to include <linux Joe Perches
2010-01-26 21:40 ` [PATCH 03/21] net/atm/atm_misc.c: checkpatch cleanups Joe Perches
2010-01-26 21:40 ` [PATCH 04/21] net/atm/atm_sysfs.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 05/21] net/atm/br2684.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 06/21] net/atm/clip.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 07/21] net/atm/common.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 08/21] net/atm/ioctl.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 09/21] net/atm/lec.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 10/21] net/atm/mpc.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 11/21] net/atm/mpoa_caches.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 12/21] net/atm/mpoa_proc.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 13/21] net/atm/pppoatm.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 14/21] net/atm/proc.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 15/21] net/atm/pvc.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 16/21] net/atm/raw.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 17/21] net/atm/resources.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 18/21] net/atm/signaling.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 19/21] net/atm/svc.c: " Joe Perches
2010-01-26 21:40 ` [PATCH 20/21] net/atm/lec.c: Add __lec_arp_check_expire and other cleanups Joe Perches
2010-01-26 21:40 ` [PATCH 21/21] net/atm: Cleanup dprint/ddprintk #defines and uses Joe Perches
2010-01-27  4:57 ` [net-next PATCH 00/21] net/atm neatening cleanups David Miller
2010-01-27  5:11   ` Joe Perches [this message]
2010-01-27  5:15     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264569109.14552.3.camel@Joe-Laptop.home \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).