From: Ben Hutchings <ben@decadent.org.uk>
To: Ajit Khaparde <ajitk@serverengines.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
stable@kernel.org, stable-review@kernel.org
Subject: Re: [PATCH] be2net: Bug fix to support newer generation of BE ASIC
Date: Thu, 28 Jan 2010 22:40:29 +0000 [thread overview]
Message-ID: <1264718429.373.520.camel@localhost> (raw)
In-Reply-To: <20100128075633.GA4785@serverengines.com>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Thu, 2010-01-28 at 13:26 +0530, Ajit Khaparde wrote:
> Bug fix in be2net for newer generation of BladeEngine ASIC.
[...]
> @@ -2162,6 +2168,7 @@ static int be_stats_init(struct be_adapter *adapter)
> cmd->va = pci_alloc_consistent(adapter->pdev, cmd->size, &cmd->dma);
> if (cmd->va == NULL)
> return -1;
> + memset(cmd->va, cmd->size, 0);
> return 0;
> }
>
[...]
I don't think this does what you think it does.
Also, you should either send this patch to stable@kernel.org, or NAK the
addition of PCI ids for BladeEngine 3 in 2.6.32.7.
Ben.
--
Ben Hutchings
You can't have everything. Where would you put it?
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2010-01-28 22:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 7:56 [PATCH] be2net: Bug fix to support newer generation of BE ASIC Ajit Khaparde
2010-01-28 22:40 ` Ben Hutchings [this message]
2010-01-28 22:51 ` [stable] " Greg KH
2010-01-28 23:20 ` Ben Hutchings
2010-01-28 23:28 ` Greg KH
2010-01-28 23:55 ` Ben Hutchings
2010-01-29 5:51 ` Ajit Khaparde
2010-01-29 5:56 ` David Miller
2010-01-29 6:47 ` Ajit Khaparde
2010-01-29 7:05 ` David Miller
2010-01-29 7:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264718429.373.520.camel@localhost \
--to=ben@decadent.org.uk \
--cc=ajitk@serverengines.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).