From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: [PATCH net-2.6] cdc_ether: Partially revert "usbnet: Set link down initially ..." Date: Thu, 28 Jan 2010 23:18:44 +0000 Message-ID: <1264720725.373.550.camel@localhost> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Cc: netdev , avi.rozen@gmail.com To: "David S. Miller" Return-path: Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:41430 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753820Ab0A1XSu convert rfc822-to-8bit (ORCPT ); Thu, 28 Jan 2010 18:18:50 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Commit 37e8273cd30592d3a82bcb70cbb1bdc4eaeb6b71 ("usbnet: Set link down initially for drivers that update link state") changed the initial link state in cdc_ether and other drivers based on the understanding that the devices they support generate link change interrupts. However, this is optional in the CDC Ethernet protocol, and two users have reported in that the link state for their devices remains down. Therefore, revert the change in cdc_ether. Signed-off-by: Ben Hutchings Tested-by: Avi Rozen --- --- a/drivers/net/usb/cdc_ether.c +++ b/drivers/net/usb/cdc_ether.c @@ -419,7 +419,7 @@ static const struct driver_info cdc_info = { .description = "CDC Ethernet Device", - .flags = FLAG_ETHER | FLAG_LINK_INTR, + .flags = FLAG_ETHER, // .check_connect = cdc_check_connect, .bind = cdc_bind, .unbind = usbnet_cdc_unbind, -- Ben Hutchings The generation of random numbers is too important to be left to chance. - Robert Coveyou