From: Eric Dumazet <eric.dumazet@gmail.com>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] af_key: fix netns ops ordering on module load/unload
Date: Mon, 01 Feb 2010 14:56:30 +0100 [thread overview]
Message-ID: <1265032590.2848.40.camel@edumazet-laptop> (raw)
In-Reply-To: <68676e01002010550l2654208dged864973a996c381@mail.gmail.com>
Le lundi 01 février 2010 à 14:50 +0100, Luca Tettamanti a écrit :
> On Sat, Jan 30, 2010 at 1:53 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > [PATCH] af_key: fix netns ops ordering on module load/unload
> >
> > 1. After sock_register() returns, it's possible to create sockets,
> > even if module still not initialized fully (blame generic module code
> > for that!)
> > 2. Consequently, pfkey_create() can be called with pfkey_net_id still not
> > initialized which will BUG_ON in net_generic():
> > kernel BUG at include/net/netns/generic.h:43!
> > 3. During netns shutdown, netns ops should be unregistered after
> > key manager unregistered because key manager calls can be triggered
> > from xfrm_user module:
> >
> > general protection fault: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC
> > pfkey_broadcast+0x111/0x210 [af_key]
> > pfkey_send_notify+0x16a/0x300 [af_key]
> > km_state_notify+0x41/0x70
> > xfrm_flush_sa+0x75/0x90 [xfrm_user]
> > 4. Unregister netns ops after socket ops just in case and for symmetry.
> >
> > Reported by Luca Tettamanti.
> >
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>
> Tested-by: Luca Tettamanti <kronos.it@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
next prev parent reply other threads:[~2010-02-01 13:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 9:48 [2.6.33-rc5] kernel BUG at include/net/netns/generic.h:41! Luca Tettamanti
2010-01-29 10:17 ` Alexey Dobriyan
2010-01-29 15:22 ` Eric Dumazet
2010-01-29 16:33 ` [PATCH] xfrm: Change initializations order in ipsec_pfkey_init() Eric Dumazet
2010-01-30 12:53 ` [PATCH] af_key: fix netns ops ordering on module load/unload Alexey Dobriyan
2010-02-01 13:50 ` Luca Tettamanti
2010-02-01 13:56 ` Eric Dumazet [this message]
2010-02-04 2:11 ` David Miller
2010-01-30 13:23 ` [2.6.33-rc5] kernel BUG at include/net/netns/generic.h:41! Luca Tettamanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265032590.2848.40.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=kronos.it@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox