From: Ron Mercer <ron.mercer@qlogic.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, ron.mercer@qlogic.com
Subject: [net-next PATCH 1/3] qlge: Move reset from eeh io_resume to slot_reset.
Date: Wed, 3 Feb 2010 09:24:11 -0800 [thread overview]
Message-ID: <1265217853-26959-2-git-send-email-ron.mercer@qlogic.com> (raw)
In-Reply-To: <1265217853-26959-1-git-send-email-ron.mercer@qlogic.com>
Issue asic reset and verify functionality before continuing to the
resume call. This allows proper error code to be returned in the case
the asic does not recover.
Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
---
drivers/net/qlge/qlge_main.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
index 5be3ae2..87ec720 100644
--- a/drivers/net/qlge/qlge_main.c
+++ b/drivers/net/qlge/qlge_main.c
@@ -4717,6 +4717,12 @@ static pci_ers_result_t qlge_io_slot_reset(struct pci_dev *pdev)
return PCI_ERS_RESULT_DISCONNECT;
}
pci_set_master(pdev);
+
+ if (ql_adapter_reset(qdev)) {
+ QPRINTK(qdev, DRV, ERR, "reset FAILED!\n");
+ return PCI_ERS_RESULT_DISCONNECT;
+ }
+
return PCI_ERS_RESULT_RECOVERED;
}
@@ -4726,8 +4732,6 @@ static void qlge_io_resume(struct pci_dev *pdev)
struct ql_adapter *qdev = netdev_priv(ndev);
int err = 0;
- if (ql_adapter_reset(qdev))
- QPRINTK(qdev, DRV, ERR, "reset FAILED!\n");
if (netif_running(ndev)) {
err = qlge_open(ndev);
if (err) {
--
1.6.0.2
next prev parent reply other threads:[~2010-02-03 17:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 17:24 [net-next PATCH 0/3] qlge: EEH fixes Ron Mercer
2010-02-03 17:24 ` Ron Mercer [this message]
2010-02-04 4:06 ` [net-next PATCH 1/3] qlge: Move reset from eeh io_resume to slot_reset David Miller
2010-02-03 17:24 ` [net-next PATCH 2/3] qlge: Add check for eeh failure when closing device Ron Mercer
2010-02-04 4:06 ` David Miller
2010-02-03 17:24 ` [net-next PATCH 3/3] qlge: Add watchdog timer Ron Mercer
2010-02-04 3:32 ` David Miller
2010-02-04 16:04 ` Ron Mercer
2010-02-04 20:06 ` Ron Mercer
2010-02-04 20:29 ` David Miller
2010-02-04 21:19 ` Ron Mercer
2010-02-04 21:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265217853-26959-2-git-send-email-ron.mercer@qlogic.com \
--to=ron.mercer@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).