From: jamal <hadi@cyberus.ca>
To: Patrick McHardy <kaber@trash.net>
Cc: "Herbert Xu" <herbert@gondor.apana.org.au>,
"David Miller" <davem@davemloft.net>,
"Timo Teräs" <timo.teras@iki.fi>,
netdev@vger.kernel.org
Subject: Re: [RFC]: xfrm by mark
Date: Mon, 08 Feb 2010 09:58:30 -0500 [thread overview]
Message-ID: <1265641110.3688.45.camel@bigi> (raw)
In-Reply-To: <4B701204.6000106@trash.net>
On Mon, 2010-02-08 at 14:30 +0100, Patrick McHardy wrote:
> If you simply add the mark to the lookup key, it will break
> existing setups already using marks. I'd suggest to also add
> a mask which is initialized to 0 when no mark attribute is
> present.
Good point - better safe than sorry (especially after the havoc
that ingress mark caused;->)
Would it be easier to just add a global sysctl with default being
"dont use marks"? It will be less memory use than a 32-bit mask per
mark..
cheers,
jamal
next prev parent reply other threads:[~2010-02-08 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-07 18:32 [RFC]: xfrm by mark jamal
2010-02-08 13:30 ` Patrick McHardy
2010-02-08 14:58 ` jamal [this message]
2010-02-08 15:00 ` Patrick McHardy
2010-02-08 15:28 ` jamal
2010-02-08 15:35 ` Patrick McHardy
2010-02-08 15:56 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265641110.3688.45.camel@bigi \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).