Re: [net-next PATCH v3 3/3] net: reserve ports for applications using fixed port numbers

[Eric Dumazet <eric.dumazet@gmail.com>]

Octavian, please resubmit all patches to lkml, netdev, David, because
patches 1 & 2 are changing kernel core services.

However, I'll take some time in a couple of hours to review them.

Le jeudi 11 février 2010 à 04:53 +0200, Octavian Purdila a écrit :
> This patch introduces /proc/sys/net/ipv4/ip_local_reserved_ports
> (bitmap type) which allows users to reserve ports for third-party
> applications.
> 
> The reserved ports will not be used by automatic port assignments
> (e.g. when calling connect() or bind() with port number 0). Explicit
> port allocation behavior is unchanged.


>  
> +extern unsigned long sysctl_local_reserved_ports[65536/8/sizeof(unsigned long)];

I am sure we have a special macro for this.

extern DECLARE_BITMAP(reserved_ports, 65536);

> +unsigned long sysctl_local_reserved_ports[65536/BITS_PER_LONG];
> +

Same point here, plus I am not sure adding 8192 bytes in BSS zone is a
problem nowadays. (It was ten years ago for some arches)