From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Levitsky Subject: Re: [PATCH 2/6] DMFE: move pci ID definitions into pci_ids.h and clean up the code Date: Thu, 11 Feb 2010 19:25:22 +0200 Message-ID: <1265909122.9788.5.camel@maxim-laptop> References: <1265487542-4447-1-git-send-email-maximlevitsky@gmail.com> <1265487542-4447-3-git-send-email-maximlevitsky@gmail.com> <20100210.131849.237007566.davem@davemloft.net> <20100210.132201.21689811.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, maxim-levitsky@gmail.com To: David Miller Return-path: Received: from fg-out-1718.google.com ([72.14.220.156]:21633 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752094Ab0BKR0a (ORCPT ); Thu, 11 Feb 2010 12:26:30 -0500 In-Reply-To: <20100210.132201.21689811.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2010-02-10 at 13:22 -0800, David Miller wrote: > From: David Miller > Date: Wed, 10 Feb 2010 13:18:49 -0800 (PST) > > > From: Maxim Levitsky > > Date: Sat, 6 Feb 2010 22:18:58 +0200 > > > >> Signed-off-by: Maxim Levitsky > > > > We don't add new definitions to pci_ids.h that will only > > be used in a single driver. No problem! Didn't know about that. > > > > Instead, we just use the raw constants (if it's only referenced once, > > say in the PCI ID table for the driver) or using local definitions > > (if used multiple times in the driver). > > BTW, the rest of your patch set is likely to not apply > correctly after you fix this patch up. So at a minimum > you'll need to resubmit this whole set after fixing > patch #2. I agree with that completely. > > In fact I would recommend that you seperate the bug > fixes from all of the massive cleanups. > > Get the bug fixes, especially the PCI READ MULTIPLE > disable one, into net-2.6 > > Then afterwards you can do all of the cleanups against > net-next-2.6 when the bug fixes propagate there. This is good idea too. I also will split the cleanups, because looking back at massive patch I understand that it is not good for review. > > Thank you! Thanks too. Best regards, Maxim Levitsky