Re: IPv6 20/62: reassembly: replace magic number with macro definitions

Joe Perches
2010-02-16T15:43:40Z

On Tue, 2010-02-16 at 15:55 +0100, Patrick McHardy wrote:
> commit 7c070aa947d1a4105742378579c267f6e7fd08a1
> Author: Shan Wei <shanwei@cn.fujitsu.com>
> Date: Wed Jan 20 10:42:41 2010 +0100
>
> IPv6: reassembly: replace magic number with macro definitions
>
> Use macro to define high/low thresh value, refer to IPV6_FRAG_TIMEOUT.
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
> Acked-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
>
> diff --git a/include/net/ipv6.h b/include/net/ipv6.h
> index ccab594..299bbf5 100644
> --- a/include/net/ipv6.h
> +++ b/include/net/ipv6.h
> @@ -246,6 +246,8 @@ extern int ipv6_opt_accepted(struct sock *sk, struct sk_buff *skb);
> int ip6_frag_nqueues(struct net *net);
> int ip6_frag_mem(struct net *net);
>
> +#define IPV6_FRAG_HIGH_THRESH 262144 /* == 256*1024 */
> +#define IPV6_FRAG_LOW_THRESH 196608 /* == 192*1024 */
> #define IPV6_FRAG_TIMEOUT (60*HZ) /* 60 seconds */

196608 isn't a number I want to remember.
Is this better as:

#define IPV6_FRAG_HIGH_THRESH (256 * 1024) /* 262144 */
#define IPV6_FRAG_LOW_THRESH (192 * 1024) /* 196608 */