Re: [net-next-2.6 PATCH 1/3] vlan: adds vlan_dev_select_queue

[Eric Dumazet <eric.dumazet@gmail.com>]

Le mercredi 17 février 2010 à 14:40 -0800, Vasu Dev a écrit :
> > > ------------------
> > > 
> > > For performance reason, we could avoid calling vlan_dev_select_queue()
> > > for real devices without ndo_select_queue() handler, this would need to
> > > mirror vlan_netdev_ops & vlan_netdev_accel_ops.
> > > 
> 
> This means vlan_netdev_ops & vlan_netdev_accel_ops not to be const
> anymore so that vlan_dev_select_queue() could be initialized to vlan ops
> based on real dev ndo_select_queue() present or not, should be okay to
> be not const anymore. I'll update patch as suggested.

No they should stay const

I said you should mirror (copy if you prefer) the structure, one with a
NULL ndo_select_queue pointer, one with a ndo_select_queue =
vlan_dev_select_queue.

Both structures are const.

You must not dynamiucally change the structure, because the same machine
might have a vlan over a device with no ndo_select_queue() method, and
another vlan over a device with a ndo_select_queue()

Thanks