From: reinette chatre <reinette.chatre@intel.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "Zhu, Yi" <yi.zhu@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
"Guy, Wey-Yi W" <wey-yi.w.guy@intel.com>,
"Kolekar, Abhijeet" <abhijeet.kolekar@intel.com>,
Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] iwlwifi: testing the wrong variable
Date: Thu, 18 Feb 2010 10:04:42 -0800 [thread overview]
Message-ID: <1266516282.2551.2604.camel@rchatre-DESK> (raw)
In-Reply-To: <20100218094529.GA1298@bicker>
On Thu, 2010-02-18 at 01:45 -0800, Dan Carpenter wrote:
> The first one fixes a smatch false positive and the second one fixes
> a potential bug.
>
> drivers/net/wireless/iwlwifi/iwl-5000.c +786 iwl5000_txq_update_byte_cnt_tbl(37) error: buffer overflow
> '(scd_bc_tbl+txq_id)->tfd_offset' 320 <= 512
> drivers/net/wireless/iwlwifi/iwl-5000.c +808 iwl5000_txq_inval_byte_cnt_tbl(19) error: buffer overflow
> '(scd_bc_tbl+txq_id)->tfd_offset' 320 <= 512
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> Cc: stable@kernel.org
> ---
This has already been fixed by patch below (taken from
wireless-next-2.6). John and Greg, could you please pick this one up for
2.6.33 and stable instead?
commit 8ce1ef4a914aef8b9b90a2a2c670494168a2cca9
Author: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Date: Fri Jan 8 10:04:44 2010 -0800
iwlwifi: fix bug in tx byte count table
When setting invalid byte count in txq byte count table, read
pointer
should be used instead of write pointer.
Reported-by: Guo, Chaohong <chaohong.guo@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: Zhu Yi <yi.zhu@intel.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Reinette
next prev parent reply other threads:[~2010-02-18 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 9:45 [patch] iwlwifi: testing the wrong variable Dan Carpenter
2010-02-18 18:04 ` reinette chatre [this message]
2010-02-19 20:30 ` John W. Linville
2010-02-19 20:57 ` reinette chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266516282.2551.2604.camel@rchatre-DESK \
--to=reinette.chatre@intel.com \
--cc=abhijeet.kolekar@intel.com \
--cc=error27@gmail.com \
--cc=ilw@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox