From: jamal <hadi@cyberus.ca>
To: David Miller <davem@davemloft.net>
Cc: adobriyan@gmail.com, netdev@vger.kernel.org
Subject: Re: regression due to "flush SAD/SPD generate false events"
Date: Thu, 18 Feb 2010 17:52:41 -0500 [thread overview]
Message-ID: <1266533561.3879.132.camel@bigi> (raw)
In-Reply-To: <20100218.142735.230862605.davem@davemloft.net>
On Thu, 2010-02-18 at 14:27 -0800, David Miller wrote:
> Let's see how #2 works out, if we get any more breakage
> cases reported then we'll have to revert again and go with
> #1.
Actually, i think i found the root cause. The sequence should be:
1) pfkey->kernel: flush
kernel flushes SA/SPD
2)kernel->pfkey: respond to flush message
3)kernel->all user space listeners: i just flushed the SA/SPD
#2 is always needed.
#3 is wrong if SA/SPD is empty.
kernel unfortunately sends a single broadcast which combines
#2 and #3. So the proper fix is to break #2 and #3 into
separate messages. And follow the rules above.
I dont have time to fix it right now - but i will send a patch
tommorow.
cheers,
jamal
next prev parent reply other threads:[~2010-02-18 22:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 19:17 regression due to "flush SAD/SPD generate false events" Alexey Dobriyan
2010-02-17 21:42 ` David Miller
2010-02-17 23:34 ` jamal
2010-02-17 23:40 ` David Miller
2010-02-17 23:49 ` jamal
2010-02-17 23:55 ` David Miller
2010-02-18 0:03 ` jamal
2010-02-17 21:42 ` jamal
2010-02-17 23:07 ` jamal
2010-02-17 23:32 ` jamal
2010-02-18 18:55 ` Alexey Dobriyan
2010-02-18 20:53 ` jamal
2010-02-18 21:45 ` jamal
2010-02-18 22:27 ` David Miller
2010-02-18 22:52 ` jamal [this message]
2010-02-18 23:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266533561.3879.132.camel@bigi \
--to=hadi@cyberus.ca \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).