From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Taku Izumi <izumi.taku@jp.fujitsu.com>
Cc: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Allan, Bruce W" <bruce.w.allan@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Ronciak, John" <john.ronciak@intel.com>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
Koki Sanagi <sanagi.koki@jp.fujitsu.com>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
"chavey@google.com" <chavey@google.com>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>
Subject: Re: [PATCH v2 0/3] e1000e,igb,ixgbe: add registers etc. printout code just before resetting adapters
Date: Fri, 19 Feb 2010 03:20:56 -0800 [thread overview]
Message-ID: <1266578456.25502.23.camel@localhost.localdomain> (raw)
In-Reply-To: <4B7E48F8.7010208@jp.fujitsu.com>
On Fri, 2010-02-19 at 01:16 -0700, Taku Izumi wrote:
> Hi Jesse,
>
> > I have a counter proposal to make, here is a (incomplete) patch that we
> > use all the time to debug tx hangs. This example is for e1000e. We are
> > trying to avoid changes with other users' copyright to some of the files
> > in our drivers so that we can ship them under multiple license. We would
> > much prefer something like this to be used, can you review?
>
> I haven't understood yet about the reason we have to avoid changing some
> files. Are there any files (header files?) we can't modify?
>
> Best regards,
> Taku Izumi
>
To answer your question, no there are no files you can't submit patches
to. We do have some common files which are used/shared amongst all of
our drivers which are used for initializing and/or bring up the
hardware, so when a patch is submitted to our drivers which changes our
"shared code" our first question is "Is this change necessary for all of
our drivers?" and if the answer is no, then we take a look at what
changes can be made in the code which is not shared among our other
drivers.
--
Cheers,
Jeff
next prev parent reply other threads:[~2010-02-19 11:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 5:45 [PATCH v2 0/3] e1000e,igb,ixgbe: add registers etc. printout code just before resetting adapters Taku Izumi
2010-01-22 5:48 ` [PATCH v2 1/3] e1000e: " Taku Izumi
2010-01-22 8:48 ` Taku Izumi
2010-02-19 19:19 ` Laurent Chavey
2010-01-22 5:49 ` [PATCH v2 2/3] igb: " Taku Izumi
2010-01-22 8:49 ` Taku Izumi
2010-01-22 5:50 ` [PATCH v2 3/3] ixgbe: " Taku Izumi
2010-01-22 8:50 ` Taku Izumi
2010-01-22 6:25 ` [PATCH v2 0/3] e1000e,igb,ixgbe: " Joe Perches
2010-01-22 8:46 ` Taku Izumi
2010-01-22 21:54 ` [PATCH v2 0/3] e1000e, igb, ixgbe: " Brandeburg, Jesse
2010-01-26 10:21 ` [PATCH v2 0/3] e1000e,igb,ixgbe: " Taku Izumi
2010-02-17 19:10 ` Brandeburg, Jesse
2010-02-17 19:32 ` Brandeburg, Jesse
2010-02-19 8:16 ` Taku Izumi
2010-02-19 11:20 ` Jeff Kirsher [this message]
2010-02-24 19:36 ` Laurent Chavey
2010-02-25 0:24 ` Taku Izumi
2010-02-25 0:30 ` Taku Izumi
2010-02-26 9:05 ` [PATCH v2 0/3] e1000e, igb, ixgbe: " Taku Izumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266578456.25502.23.camel@localhost.localdomain \
--to=jeffrey.t.kirsher@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=chavey@google.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=izumi.taku@jp.fujitsu.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=sanagi.koki@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).