From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH] packet: convert socket list to RCU (v3) Date: Sat, 20 Feb 2010 04:39:26 +0100 Message-ID: <1266637166.2839.1.camel@edumazet-laptop> References: <20100219215913.819285957@vyatta.com> <20100219220111.772997037@vyatta.com> <20100219142359.467b9440@nehalam> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Alexander Viro , Andrew Morton , Rusty Russell , Peter Oberparleiter , Miklos Szeredi , "Paul E. McKenney" , "David S. Miller" , Jiri Pirko , Jiri Olsa , Ingo Molnar , Alexey Dobriyan , Jamal Hadi Salim , Neil Horman , netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from mail-bw0-f209.google.com ([209.85.218.209]:47087 "EHLO mail-bw0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753004Ab0BTDjc (ORCPT ); Fri, 19 Feb 2010 22:39:32 -0500 Received: by bwz1 with SMTP id 1so561321bwz.21 for ; Fri, 19 Feb 2010 19:39:30 -0800 (PST) In-Reply-To: <20100219142359.467b9440@nehalam> Sender: netdev-owner@vger.kernel.org List-ID: Le vendredi 19 f=C3=A9vrier 2010 =C3=A0 14:23 -0800, Stephen Hemminger = a =C3=A9crit : > Convert AF_PACKET to use RCU, eliminating one more reader/writer lock= =2E >=20 > There is no need for a real sk_del_node_init_rcu(), because sk_del_no= de_init > is doing the equivalent thing to hlst_del_init_rcu already; but added > some comments to try and make that obvious. >=20 > Signed-off-by: Stephen Hemminger >=20 > --- > v2 - > v3: Need to not call remove_packet with lock held. >=20 > include/net/netns/packet.h | 4 ++-- > include/net/sock.h | 10 ++++++++++ > net/packet/af_packet.c | 42 ++++++++++++++++++++--------------= -------- > 3 files changed, 32 insertions(+), 24 deletions(-) Signed-off-by: Eric Dumazet Thanks Stephen