Re: [PATCH net-next 14/15] drivers/net/typhoon.c: Use (pr|netdev)_ macro helpers

David Miller
2010-02-18T02:40:45Z

From: David Dillow <dave@thedillows.org>
Date: Wed, 17 Feb 2010 21:30:21 -0500

> No, because the routines that use tp->name are called both before and
> after the netdev is registered. Prior to that time, it contains the PCI
> slot name -- "00:01.0" etc -- so that the user can determine which card
> is acting up. Once the card is registered, it has "ethX" to use a
> commonly expected name for the card.

In my opinion that's awful.

Pick one or the other format. For things that happen both
before and after netdev registry we really should provide
one style of device identification and those provided
by dev_*() are probably the best in these situations.