Re: [PATCH V2 net-next 14/15] drivers/net/typhoon.c: Use (pr|netdev)_ macro helpers

David Dillow
2010-02-22T03:23:18Z

On Sun, 2010-02-21 at 19:08 -0800, Joe Perches wrote:
> David Dillow took my suggestions and improved on them.
> Here is this latest version.
>
> Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> Remove #define PFX
> Remove #define ERR_PFX
> Remove now unused member name from struct typhoon
> Use pr_<level>
> Use netdev_<level>
> Coalesce long formats
> Remove version information
>
> Signed-off-by: Joe Perches <joe@perches.com>
> Signed-off-by: David Dillow <dave@thedillows.org>

Perhaps commit text as follows? I can sign-off on it, but I don't think
my effort rises to that level. I certainly ack the patch, though.

typhoon: clean up message output

Use the new netdev_* helpers to clean up and make the logging output
more consistent with other network drivers. This also removes the
constantly-stale version info in favor of using the kernel version from
which the module was built.

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: David Dillow <dave@thedillows.org>