Re: [PATCH net-next 14/15] drivers/net/typhoon.c: Use (pr|netdev)_ macro helpers

David Miller
2010-02-18T03:09:51Z

From: David Dillow <dave@thedillows.org>
Date: Wed, 17 Feb 2010 22:01:04 -0500

> On Wed, 2010-02-17 at 18:41 -0800, David Miller wrote:
>> From: David Dillow <dave@thedillows.org>
>> Date: Wed, 17 Feb 2010 21:30:21 -0500
>>
>> > No, because the routines that use tp->name are called both before and
>> > after the netdev is registered. Prior to that time, it contains the PCI
>> > slot name -- "00:01.0" etc -- so that the user can determine which card
>> > is acting up. Once the card is registered, it has "ethX" to use a
>> > commonly expected name for the card.
>>
>> In my opinion that's awful.
>
> Neither you nor Jeff seemed to think it was an issue 7+ years ago, and
> Jeff liked it when it was suggested as a solution to another driver's
> problems.

I didn't even realize it was an issue and we also didn't have the nice
dev_*() macros back there.

> But times change, sure. And people learn from experience.

Right.

> I liked it because it consistent with eth device naming when it could
> be, and gave them useful info to go on when it failed during
> initialization.

How can printing a PCI device name string be consistent with eth
device naming?

> I'm perfectly fine with the netdev_<level> changes, and can grudgingly
> live with the overlong format strings, but the pr_<level> changes make
> the output worse, and don't help readability or maintainability in my
> opinion. I'm don't see how dropping the typhoon patch slows Joe down, so
> I'd like to avoid having to fix things up after the fact.

I already tossed his patch from my tree.