Re: [PATCH V2 net-next 14/15] drivers/net/typhoon.c: Use (pr|netdev)_ macro helpers

David Miller
2010-02-22T23:42:48Z

From: David Dillow <dave@thedillows.org>
Date: Sun, 21 Feb 2010 22:23:15 -0500

> On Sun, 2010-02-21 at 19:08 -0800, Joe Perches wrote:
>> David Dillow took my suggestions and improved on them.
>> Here is this latest version.
>>
>> Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>> Remove #define PFX
>> Remove #define ERR_PFX
>> Remove now unused member name from struct typhoon
>> Use pr_<level>
>> Use netdev_<level>
>> Coalesce long formats
>> Remove version information
>>
>> Signed-off-by: Joe Perches <joe@perches.com>
>> Signed-off-by: David Dillow <dave@thedillows.org>
>
> Perhaps commit text as follows?

Man you are picky :-/ Are you a control freak?

You can't even let Joe write his commit comments consistently with the
ones he is using for all the other similar network driver transmations?

What makes doing the same exact transformations to your favorite
driver so special that it deserves a specially constructed commit
message?

Tell me.

Stuff like this drives me crazy.