From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "jeff@garzik.org" <jeff@garzik.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>
Subject: Re: [ethtool PATCH] ethtool: Support n-tuple filter programming
Date: Thu, 25 Feb 2010 22:09:07 -0800 [thread overview]
Message-ID: <1267164547.2942.2.camel@localhost> (raw)
In-Reply-To: <20100225.215357.140469725.davem@davemloft.net>
On Thu, 2010-02-25 at 21:53 -0800, David Miller wrote:
> From: Jeff Garzik <jeff@garzik.org>
> Date: Thu, 25 Feb 2010 21:26:38 -0500
>
> > On 02/25/2010 08:49 PM, Waskiewicz Jr, Peter P wrote:
> >> This will require a small kernel change. Will something like this be
> >> pulled in at this point, given that 2.6.33 just released?
> >
> > The n-tuple stuff is not in 2.6.33's ethtool interface, so it hasn't
> > actually made it into a released kernel at this point.
> >
> > It seems reasonable for 2.6.34 to either add ETHTOOL_GSTRINGS_COUNT or
> > update drvinfo. Even if net-next has already been pulled into
> > post-2.6.33 merge window, that would IMO qualify as a reasonable
> > interface bugfix to get upstream. The ethtool n-tuple ABI is not
> > locked into stone until 2.6.34 is released by Linus.
>
> Right.
Sounds good. I wanted to make sure before I changed the ethtool bits.
Expect a patch for both the kernel side and userspace side shortly.
-PJ
next prev parent reply other threads:[~2010-02-26 6:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 7:51 [ethtool PATCH] ethtool: Support n-tuple filter programming Jeff Kirsher
2010-02-25 3:41 ` Jeff Garzik
2010-02-25 7:04 ` Waskiewicz Jr, Peter P
2010-02-25 10:26 ` Jeff Garzik
2010-02-26 1:49 ` Waskiewicz Jr, Peter P
2010-02-26 2:26 ` Jeff Garzik
2010-02-26 5:53 ` David Miller
2010-02-26 6:09 ` Peter P Waskiewicz Jr [this message]
2010-02-26 19:59 ` Ben Hutchings
2010-02-26 21:05 ` Jeff Garzik
2010-06-21 19:57 ` Ben Hutchings
2010-06-21 20:31 ` Peter P Waskiewicz Jr
2010-06-21 20:49 ` Mitchell Erblich
2010-06-22 6:42 ` Peter P Waskiewicz Jr
2010-06-22 11:45 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267164547.2942.2.camel@localhost \
--to=peter.p.waskiewicz.jr@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).