From: Eric Dumazet <eric.dumazet@gmail.com>
To: Zhu Yi <yi.zhu@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Shi, Alex" <alex.shi@intel.com>
Subject: Re: [RFC PATCH] accounting for socket backlog
Date: Mon, 01 Mar 2010 04:12:40 +0100 [thread overview]
Message-ID: <1267413160.9082.120.camel@edumazet-laptop> (raw)
In-Reply-To: <1267412604.23196.53.camel@debian>
Le lundi 01 mars 2010 à 11:03 +0800, Zhu Yi a écrit :
> This is my original plan. But davem just mentioned we have to prevent
> from maliciously send frames, that means all protocols using backlog.
> That makes me consider if I should put the check to the generic path.
>
Sure, check could be done in sk_add_backlog() (including the
atomic_inc(&sk->sk_drops); and kfree_skb(skb);), but make sure a status
is returned so that we can increment SNMP counters at protocol level.
prev parent reply other threads:[~2010-03-01 3:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 3:13 [RFC PATCH] accounting for socket backlog Zhu Yi
2010-02-25 8:31 ` David Miller
2010-02-26 2:44 ` Zhu Yi
2010-02-26 5:52 ` David Miller
2010-02-25 11:24 ` Eric Dumazet
2010-02-26 2:34 ` Zhu Yi
2010-02-26 13:12 ` Eric Dumazet
2010-03-01 2:17 ` Zhu Yi
2010-03-01 2:29 ` Eric Dumazet
2010-03-01 3:03 ` Zhu Yi
2010-03-01 3:12 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267413160.9082.120.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=alex.shi@intel.com \
--cc=netdev@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox