From: Pavel Roskin <proski@gnu.org>
To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
tcpdump-workers@lists.tcpdump.org
Cc: Jiri Pirko <jpirko@redhat.com>
Subject: Current wireless-testing breaks libpcap: mr_alen should be set
Date: Tue, 02 Mar 2010 20:00:48 -0500 [thread overview]
Message-ID: <1267578048.14049.11.camel@mj> (raw)
Hello!
The current wireless-testing appears to have some non-wireless bits from
the upcoming Linux 2.6.34. As a result, libpcap and all capture
programs that use it are broken.
This patch to libpcap helps:
--- a/pcap-linux.c
+++ b/pcap-linux.c
@@ -1563,6 +1563,7 @@ live_open_new(pcap_t *handle, const char
memset(&mr, 0, sizeof(mr));
mr.mr_ifindex = handle->md.ifindex;
mr.mr_type = PACKET_MR_PROMISC;
+ mr.mr_alen = 6;
if (setsockopt(sock_fd, SOL_PACKET,
PACKET_ADD_MEMBERSHIP, &mr, sizeof(mr)) == -1)
{
libpcap git doesn't have the fix yet.
The breakage must be coming from the commit 914c8ad2 by Jiri Pirko to
net/packet/af_packet.c
I think it's very unhelpful to introduce patches that break significant
userspace functionality without giving the affected programs an advance
warning.
Also, pulling bleeding edge stuff into wireless-testing before rc1
appears to be either a mistake or a bad decision.
Sorry for cross-post, but it's an urgent issue. Repliers are encouraged
to trim the recipient list as necessary.
--
Regards,
Pavel Roskin
next reply other threads:[~2010-03-03 1:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 1:00 Pavel Roskin [this message]
2010-03-03 2:36 ` Current wireless-testing breaks libpcap: mr_alen should be set John W. Linville
2010-03-03 6:24 ` Jiri Pirko
2010-03-03 6:57 ` Pavel Roskin
2010-03-03 6:40 ` [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del] Jiri Pirko
2010-03-03 7:01 ` Pavel Roskin
2010-03-03 7:36 ` Jiri Pirko
[not found] ` <20100303064001.GB2648-YzwxZg+R7et1/kRsl7OVgNvLeJWuRmrY@public.gmane.org>
2010-03-03 6:57 ` Eric Dumazet
2010-03-03 9:05 ` Jiri Pirko
[not found] ` <20100303090512.GB2961-YzwxZg+R7evMbnheQZGK0N5OCZ2W11yPFxja6HXR22MAvxtiuMwx3w@public.gmane.org>
2010-03-03 9:06 ` David Miller
2010-03-03 9:06 ` David Miller
2010-03-03 15:31 ` Current wireless-testing breaks libpcap: mr_alen should be set Frank W. Miller
2010-03-03 15:54 ` [tcpdump-workers] " Jiri Pirko
2010-03-06 21:23 ` Guy Harris
2010-03-08 8:11 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267578048.14049.11.camel@mj \
--to=proski@gnu.org \
--cc=jpirko@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tcpdump-workers@lists.tcpdump.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).