Re: [PATCH 1/8] net: add limit for socket backlog

[Eric Dumazet <eric.dumazet@gmail.com>]

Le mercredi 03 mars 2010 à 15:35 +0800, Zhu Yi a écrit :
> On Wed, 2010-03-03 at 14:54 +0800, Eric Dumazet wrote:
> > > diff --git a/include/net/sock.h b/include/net/sock.h
> > > index 6cb1676..847119a 100644
> > > --- a/include/net/sock.h
> > > +++ b/include/net/sock.h
> > > @@ -253,6 +253,8 @@ struct sock {
> > >  	struct {
> > >  		struct sk_buff *head;
> > >  		struct sk_buff *tail;
> > > +		int len;
> > > +		int limit;
> > 
> > This new limit field is really not needed
> 
> sk->sk_rcvbuf can be adjusted by setsockopt from user at run time. The
> minimum allowed value is 256. I'm afraid this will break most protocols.

I see, then maybe use some offset in your test, to allow some extra
space.

#define MINBACKLOG 2048

if (sk->sk_backlog.len >= (sk->sk_rcvbuf << 1) + MINBACKLOG)
	return -ENOBUFS;