From: Eric Dumazet <eric.dumazet@gmail.com>
To: Zhu Yi <yi.zhu@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
"Pekka Savola (ipv6)" <pekkas@netcore.fi>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH V2 2/7] tcp: use limited socket backlog
Date: Wed, 03 Mar 2010 11:07:23 +0100 [thread overview]
Message-ID: <1267610843.2997.7.camel@edumazet-laptop> (raw)
In-Reply-To: <1267607162.2370.169.camel@debian>
Le mercredi 03 mars 2010 à 17:06 +0800, Zhu Yi a écrit :
> I simply follow how the code is originally written. As you can see,
> tcp_v4_do_rcv() doesn't always do so. And in the backlog queuing place,
> we don't even bother to check.
You add a new point where a packet can be dropped, this should be
accounted for, so that admins can have a clue whats going on.
Previously, packet was always queued, and dropped later (and accounted)
Not everybody runs drop monitor :)
next prev parent reply other threads:[~2010-03-03 10:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 8:36 [PATCH V2 1/7] net: add limit for socket backlog Zhu Yi
2010-03-03 8:36 ` [PATCH V2 2/7] tcp: use limited " Zhu Yi
2010-03-03 8:36 ` [PATCH V2 3/7] udp: " Zhu Yi
[not found] ` <1267605389-7369-4-git-send-email-yi.zhu@intel.com>
2010-03-03 8:36 ` [PATCH V2 5/7] sctp: " Zhu Yi
2010-03-03 8:36 ` [PATCH V2 6/7] tipc: " Zhu Yi
2010-03-03 8:36 ` [PATCH V2 7/7] net: backlog functions rename Zhu Yi
2010-03-03 14:10 ` [PATCH V2 5/7] sctp: use limited socket backlog Vlad Yasevich
2010-03-03 14:19 ` Zhu, Yi
2010-03-03 14:36 ` Vlad Yasevich
2010-03-04 2:00 ` Zhu, Yi
2010-03-03 8:53 ` [PATCH V2 2/7] tcp: " Eric Dumazet
2010-03-03 9:06 ` Zhu Yi
2010-03-03 10:07 ` Eric Dumazet [this message]
2010-03-03 14:12 ` Zhu, Yi
2010-03-03 14:31 ` Eric Dumazet
2010-03-04 5:21 ` Zhu, Yi
2010-03-04 6:00 ` Eric Dumazet
2010-03-04 11:04 ` Zhu, Yi
2010-03-04 14:56 ` Eric Dumazet
2010-03-03 8:54 ` [PATCH V2 1/7] net: add limit for " David Miller
2010-03-03 9:01 ` Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267610843.2997.7.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox