From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Zhu, Yi" <yi.zhu@intel.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Vlad Yasevich <vladislav.yasevich@hp.com>,
Sridhar Samudrala <sri@us.ibm.com>
Subject: RE: [PATCH V3 5/8] sctp: use limited socket backlog
Date: Fri, 05 Mar 2010 14:24:02 +0100 [thread overview]
Message-ID: <1267795442.3280.1.camel@edumazet-laptop> (raw)
In-Reply-To: <DA586906BA1FFC4384FCFD6429ECE860A4604767@shzsmsx502.ccr.corp.intel.com>
Le vendredi 05 mars 2010 à 19:05 +0800, Zhu, Yi a écrit :
> I don't see how the order is important here. We are under sock_lock
> here thus nobody will race with us. IMHO, the comment talks about
> if a packet is queued into the backlog, we need to increase the assoc/ep
> reference count. Otherwise the assoc/ep might be disappeared when
> we are about to process it (by sctp_backlog_rcv) sometime later.
>
OK then.
Its strange this protocol has to increase a refcount for each queued
frame in its backlog, but this is unrelated to your changes anyway.
next prev parent reply other threads:[~2010-03-05 13:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1267761707-15605-1-git-send-email-yi.zhu@intel.com>
2010-03-05 4:01 ` [PATCH V3 2/8] tcp: use limited socket backlog Zhu Yi
2010-03-05 4:01 ` [PATCH V3 3/8] udp: " Zhu Yi
2010-03-05 4:01 ` [PATCH V3 4/8] llc: " Zhu Yi
2010-03-05 4:01 ` [PATCH V3 5/8] sctp: " Zhu Yi
2010-03-05 6:28 ` Eric Dumazet
2010-03-05 11:05 ` Zhu, Yi
2010-03-05 13:24 ` Eric Dumazet [this message]
2010-03-05 13:30 ` Vlad Yasevich
[not found] ` <1267761707-15605-6-git-send-email-yi.zhu@intel.com>
2010-03-05 4:01 ` [PATCH V3 7/8] x25: " Zhu Yi
2010-03-05 4:01 ` [PATCH V3 8/8] net: backlog functions rename Zhu Yi
2010-03-05 6:32 ` Eric Dumazet
2010-03-05 21:36 ` David Miller
2010-03-05 6:30 ` [PATCH V3 7/8] x25: use limited socket backlog Eric Dumazet
2010-03-05 6:30 ` [PATCH V3 6/8] tipc: " Eric Dumazet
2010-03-05 20:48 ` Stephens, Allan
2010-03-05 6:22 ` [PATCH V3 4/8] llc: " Eric Dumazet
2010-03-05 13:00 ` Arnaldo Carvalho de Melo
2010-03-05 6:21 ` [PATCH V3 3/8] udp: " Eric Dumazet
2010-03-05 6:19 ` [PATCH V3 2/8] tcp: " Eric Dumazet
2010-03-08 9:21 ` Eric Dumazet
2010-03-08 18:46 ` David Miller
2010-03-05 13:00 ` [PATCH V3 1/8] net: add limit for " Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267795442.3280.1.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
--cc=vladislav.yasevich@hp.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox