From: Louis Rilling <louis.rilling@kerlabs.com>
To: mcarlson@broadcom.com
Cc: mchan@broadcom.com, netdev@vger.kernel.org,
Louis Rilling <louis.rilling@kerlabs.com>,
stable@vger.kernel.org
Subject: [PATCH] tg3: Fix tg3_poll_controller() passing wrong pointer to tg3_interrupt()
Date: Tue, 9 Mar 2010 16:47:35 +0100 [thread overview]
Message-ID: <1268149655-13193-1-git-send-email-louis.rilling@kerlabs.com> (raw)
Commit 09943a1819a240ff4a72f924d0038818fcdd0a90
Author: Matt Carlson <mcarlson@broadcom.com>
Date: Fri Aug 28 14:01:57 2009 +0000
tg3: Convert ISR parameter to tnapi
forgot to update tg3_poll_controller(), leading to intermittent crashes with
netpoll.
Fix this.
Signed-off-by: Louis Rilling <louis.rilling@kerlabs.com>
Cc: stable@vger.kernel.org
---
drivers/net/tg3.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 0fa7688..c3b4fe7 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -5279,7 +5279,7 @@ static void tg3_poll_controller(struct net_device *dev)
struct tg3 *tp = netdev_priv(dev);
for (i = 0; i < tp->irq_cnt; i++)
- tg3_interrupt(tp->napi[i].irq_vec, dev);
+ tg3_interrupt(tp->napi[i].irq_vec, &tp->napi[i]);
}
#endif
--
1.5.6.5
next reply other threads:[~2010-03-09 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 15:47 Louis Rilling [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-03-09 16:14 [PATCH] tg3: Fix tg3_poll_controller() passing wrong pointer to tg3_interrupt() Louis Rilling
2010-03-10 15:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268149655-13193-1-git-send-email-louis.rilling@kerlabs.com \
--to=louis.rilling@kerlabs.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).