* [PATCH] tg3: Fix tg3_poll_controller() passing wrong pointer to tg3_interrupt()
@ 2010-03-09 15:47 Louis Rilling
0 siblings, 0 replies; 3+ messages in thread
From: Louis Rilling @ 2010-03-09 15:47 UTC (permalink / raw)
To: mcarlson; +Cc: mchan, netdev, Louis Rilling, stable
Commit 09943a1819a240ff4a72f924d0038818fcdd0a90
Author: Matt Carlson <mcarlson@broadcom.com>
Date: Fri Aug 28 14:01:57 2009 +0000
tg3: Convert ISR parameter to tnapi
forgot to update tg3_poll_controller(), leading to intermittent crashes with
netpoll.
Fix this.
Signed-off-by: Louis Rilling <louis.rilling@kerlabs.com>
Cc: stable@vger.kernel.org
---
drivers/net/tg3.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 0fa7688..c3b4fe7 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -5279,7 +5279,7 @@ static void tg3_poll_controller(struct net_device *dev)
struct tg3 *tp = netdev_priv(dev);
for (i = 0; i < tp->irq_cnt; i++)
- tg3_interrupt(tp->napi[i].irq_vec, dev);
+ tg3_interrupt(tp->napi[i].irq_vec, &tp->napi[i]);
}
#endif
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] tg3: Fix tg3_poll_controller() passing wrong pointer to tg3_interrupt()
@ 2010-03-09 16:14 Louis Rilling
2010-03-10 15:33 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Louis Rilling @ 2010-03-09 16:14 UTC (permalink / raw)
To: Matt Carlson; +Cc: Louis Rilling, Michael Chan, netdev, stable
[Resending without buggy address for stable. Sorry.]
Commit 09943a1819a240ff4a72f924d0038818fcdd0a90
Author: Matt Carlson <mcarlson@broadcom.com>
Date: Fri Aug 28 14:01:57 2009 +0000
tg3: Convert ISR parameter to tnapi
forgot to update tg3_poll_controller(), leading to intermittent crashes with
netpoll.
Fix this.
Signed-off-by: Louis Rilling <louis.rilling@kerlabs.com>
Cc: stable@kernel.org
---
drivers/net/tg3.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 0fa7688..c3b4fe7 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -5279,7 +5279,7 @@ static void tg3_poll_controller(struct net_device *dev)
struct tg3 *tp = netdev_priv(dev);
for (i = 0; i < tp->irq_cnt; i++)
- tg3_interrupt(tp->napi[i].irq_vec, dev);
+ tg3_interrupt(tp->napi[i].irq_vec, &tp->napi[i]);
}
#endif
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tg3: Fix tg3_poll_controller() passing wrong pointer to tg3_interrupt()
2010-03-09 16:14 Louis Rilling
@ 2010-03-10 15:33 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-03-10 15:33 UTC (permalink / raw)
To: louis.rilling; +Cc: mcarlson, mchan, netdev, stable
From: Louis Rilling <louis.rilling@kerlabs.com>
Date: Tue, 9 Mar 2010 17:14:41 +0100
> [Resending without buggy address for stable. Sorry.]
>
> Commit 09943a1819a240ff4a72f924d0038818fcdd0a90
> Author: Matt Carlson <mcarlson@broadcom.com>
> Date: Fri Aug 28 14:01:57 2009 +0000
>
> tg3: Convert ISR parameter to tnapi
>
> forgot to update tg3_poll_controller(), leading to intermittent crashes with
> netpoll.
>
> Fix this.
>
> Signed-off-by: Louis Rilling <louis.rilling@kerlabs.com>
> Cc: stable@kernel.org
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-10 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-09 15:47 [PATCH] tg3: Fix tg3_poll_controller() passing wrong pointer to tg3_interrupt() Louis Rilling
-- strict thread matches above, loose matches on Subject: below --
2010-03-09 16:14 Louis Rilling
2010-03-10 15:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).