From: Stanislaw Gruszka <sgruszka@redhat.com>
To: netdev@vger.kernel.org
Cc: Vladislav Zolotarov <vladz@broadcom.com>,
Eilon Greenstein <eilong@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: [PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations
Date: Tue, 9 Mar 2010 17:55:00 +0100 [thread overview]
Message-ID: <1268153703-4186-1-git-send-email-sgruszka@redhat.com> (raw)
Since we want to keep ordering of write to fp->bd_tx_cons and
netif_tx_queue_stopped(txq), what is read of txq->state, we have to use
general memory barrier.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/bnx2x_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index ed785a3..9fc0f6a 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -963,7 +963,7 @@ static int bnx2x_tx_int(struct bnx2x_fastpath *fp)
* start_xmit() will miss it and cause the queue to be stopped
* forever.
*/
- smp_wmb();
+ smp_mb();
/* TBD need a thresh? */
if (unlikely(netif_tx_queue_stopped(txq))) {
--
1.6.2.5
next reply other threads:[~2010-03-09 16:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 16:55 Stanislaw Gruszka [this message]
2010-03-09 16:55 ` [PATCH 2/4] bnx2x: remove not necessary compiler barrier Stanislaw Gruszka
2010-03-09 16:55 ` [PATCH 3/4] bnx2x: change smp_mb() comment to conform the true Stanislaw Gruszka
2010-03-09 16:55 ` [PATCH 4/4] bnx2x: merge common code when stopping queue Stanislaw Gruszka
2010-03-10 16:02 ` Eilon Greenstein
2010-03-10 16:01 ` [PATCH 3/4] bnx2x: change smp_mb() comment to conform the true Eilon Greenstein
2010-03-15 22:47 ` David Miller
2010-03-10 16:00 ` [PATCH 2/4] bnx2x: remove not necessary compiler barrier Eilon Greenstein
2010-03-15 22:47 ` David Miller
2010-03-10 15:59 ` [PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations Eilon Greenstein
2010-03-15 22:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268153703-4186-1-git-send-email-sgruszka@redhat.com \
--to=sgruszka@redhat.com \
--cc=eilong@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).