* [PATCH 0/2] TI DaVinci EMAC: Add support for handling PHY Clock. @ 2010-03-11 14:24 Sriramakrishnan 2010-03-11 14:24 ` [PATCH 1/2] TI DaVinci EMAC: Add EMAC PHY clock handling Sriramakrishnan 0 siblings, 1 reply; 7+ messages in thread From: Sriramakrishnan @ 2010-03-11 14:24 UTC (permalink / raw) To: netdev, davinci-linux-open-source; +Cc: nsekhar, Sriramakrishnan In addition to the EMAC module clock, the EMAC PHY clock needs to be managed separately. Until now, on most DaVinci platforms, the PHY clock is always enabled. On AM35x platform where the same EMAC module is used, the PHY clock needs to be managed explicitly. This patch series add support for handling PHY clock in the EMAC driver. Clock definitions for platforms using the EMAC module have be modified accordingly. This patch series is generated against tip of Linus tree and depends on the following patches submitted earlier [1].http://patchwork.ozlabs.org/patch/47156/ [2].http://patchwork.ozlabs.org/patch/47303/ Sekhar Nori (1): davinci: introduce EMAC PHY clock usage Sriramakrishnan (1): TI DaVinci EMAC: Add EMAC PHY clock handling. arch/arm/mach-davinci/board-da830-evm.c | 19 +++++++++++++++++++ arch/arm/mach-davinci/board-da850-evm.c | 21 +++++++++++++++++++++ arch/arm/mach-davinci/board-dm365-evm.c | 18 ++++++++++++++++++ arch/arm/mach-davinci/board-dm644x-evm.c | 18 ++++++++++++++++++ arch/arm/mach-davinci/board-dm646x-evm.c | 15 +++++++++++++++ arch/arm/mach-davinci/board-neuros-osd2.c | 19 +++++++++++++++++++ arch/arm/mach-davinci/board-sffsdr.c | 19 +++++++++++++++++++ arch/arm/mach-davinci/da830.c | 2 +- arch/arm/mach-davinci/da850.c | 2 +- arch/arm/mach-davinci/dm365.c | 2 +- arch/arm/mach-davinci/dm644x.c | 2 +- arch/arm/mach-davinci/dm646x.c | 2 +- drivers/net/davinci_emac.c | 22 ++++++++++++++++++++-- 13 files changed, 154 insertions(+), 7 deletions(-) ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] TI DaVinci EMAC: Add EMAC PHY clock handling. 2010-03-11 14:24 [PATCH 0/2] TI DaVinci EMAC: Add support for handling PHY Clock Sriramakrishnan @ 2010-03-11 14:24 ` Sriramakrishnan [not found] ` <1268317491-3822-2-git-send-email-srk-l0cyMroinI0@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Sriramakrishnan @ 2010-03-11 14:24 UTC (permalink / raw) To: netdev, davinci-linux-open-source; +Cc: nsekhar, Sriramakrishnan Source for the EMAC PHY clock can be different from the module clock and driver needs to request/enable the EMAC phy clock explicitly. This was not required earlier as on most Davinci platforms the phy clock is always on . On AM35x platform the phy clock needs to be managed explicitly , hence adding clock management for phy clock. Signed-off-by: Sriramakrishnan <srk@ti.com> --- drivers/net/davinci_emac.c | 22 ++++++++++++++++++++-- 1 files changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c index 8a42dbe..d9ae6ee 100644 --- a/drivers/net/davinci_emac.c +++ b/drivers/net/davinci_emac.c @@ -491,6 +491,7 @@ struct emac_priv { /* clock frequency for EMAC */ static struct clk *emac_clk; +static struct clk *emac_phy_clk; static unsigned long emac_bus_frequency; static unsigned long mdio_max_freq; @@ -2637,18 +2638,28 @@ static int __devinit davinci_emac_probe(struct platform_device *pdev) struct emac_platform_data *pdata; struct device *emac_dev; - /* obtain emac clock from kernel */ - emac_clk = clk_get(&pdev->dev, NULL); + /* obtain emac module clock from kernel */ + emac_clk = clk_get(&pdev->dev, "emac_clk"); if (IS_ERR(emac_clk)) { printk(KERN_ERR "DaVinci EMAC: Failed to get EMAC clock\n"); return -EBUSY; } + + /* obtain emac phy clock from kernel */ + emac_phy_clk = clk_get(&pdev->dev, "phy_clk"); + if (IS_ERR(emac_phy_clk)) { + printk(KERN_ERR "DaVinci EMAC: Failed to get PHY clock\n"); + clk_put(emac_clk); + return -EBUSY; + } + emac_bus_frequency = clk_get_rate(emac_clk); /* TODO: Probe PHY here if possible */ ndev = alloc_etherdev(sizeof(struct emac_priv)); if (!ndev) { printk(KERN_ERR "DaVinci EMAC: Error allocating net_device\n"); + clk_put(emac_phy_clk); clk_put(emac_clk); return -ENOMEM; } @@ -2734,6 +2745,7 @@ static int __devinit davinci_emac_probe(struct platform_device *pdev) netif_napi_add(ndev, &priv->napi, emac_poll, EMAC_POLL_WEIGHT); clk_enable(emac_clk); + clk_enable(emac_phy_clk); /* register the network device */ SET_NETDEV_DEV(ndev, &pdev->dev); @@ -2783,6 +2795,7 @@ mdiobus_quit: netdev_reg_err: mdio_alloc_err: + clk_disable(emac_phy_clk); clk_disable(emac_clk); no_irq_res: res = platform_get_resource(pdev, IORESOURCE_MEM, 0); @@ -2790,6 +2803,7 @@ no_irq_res: iounmap(priv->remap_addr); probe_quit: + clk_put(emac_phy_clk); clk_put(emac_clk); free_netdev(ndev); return rc; @@ -2821,7 +2835,9 @@ static int __devexit davinci_emac_remove(struct platform_device *pdev) free_netdev(ndev); iounmap(priv->remap_addr); + clk_disable(emac_phy_clk); clk_disable(emac_clk); + clk_put(emac_phy_clk); clk_put(emac_clk); return 0; @@ -2835,6 +2851,7 @@ static int davinci_emac_suspend(struct device *dev) if (netif_running(ndev)) emac_dev_stop(ndev); + clk_disable(emac_phy_clk); clk_disable(emac_clk); return 0; @@ -2846,6 +2863,7 @@ static int davinci_emac_resume(struct device *dev) struct net_device *ndev = platform_get_drvdata(pdev); clk_enable(emac_clk); + clk_enable(emac_phy_clk); if (netif_running(ndev)) emac_dev_open(ndev); -- 1.6.2.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
[parent not found: <1268317491-3822-2-git-send-email-srk-l0cyMroinI0@public.gmane.org>]
* [PATCH 2/2] davinci: introduce EMAC PHY clock usage [not found] ` <1268317491-3822-2-git-send-email-srk-l0cyMroinI0@public.gmane.org> @ 2010-03-11 14:24 ` Sriramakrishnan 2010-03-12 22:38 ` Kevin Hilman 2010-03-12 22:27 ` [PATCH 1/2] TI DaVinci EMAC: Add EMAC PHY clock handling Kevin Hilman 1 sibling, 1 reply; 7+ messages in thread From: Sriramakrishnan @ 2010-03-11 14:24 UTC (permalink / raw) To: netdev-u79uwXL29TY76Z2rM5mHXA, davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/ From: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org> The patch "TI DaVinci EMAC: Add EMAC PHY clock handling" adds support for enabling and disabling the EMAC PHY clock. The PHY clock on all DaVinci boards is derived from a fixed on board clock. This patch adds the PHY clock definition to the clock tree for all the DaVinci boards using EMAC. Also, the existing input to EMAC module is differentiated from the PHY clock using the clock name "emac_clk". Without this patch ethernet fails to initialize since it cannot get the PHY clock and EMAC clock. Tested on EVM boards for DM365, DM6467, DM644x, DA830 and DA850. Signed-off-by: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org> --- Though i have made changes for Neuros OSD2 and SFFSDR boards, i do not have the hardware to test. Appreciate if folks having this hardware ack the patch. arch/arm/mach-davinci/board-da830-evm.c | 19 +++++++++++++++++++ arch/arm/mach-davinci/board-da850-evm.c | 21 +++++++++++++++++++++ arch/arm/mach-davinci/board-dm365-evm.c | 18 ++++++++++++++++++ arch/arm/mach-davinci/board-dm644x-evm.c | 18 ++++++++++++++++++ arch/arm/mach-davinci/board-dm646x-evm.c | 15 +++++++++++++++ arch/arm/mach-davinci/board-neuros-osd2.c | 19 +++++++++++++++++++ arch/arm/mach-davinci/board-sffsdr.c | 19 +++++++++++++++++++ arch/arm/mach-davinci/da830.c | 2 +- arch/arm/mach-davinci/da850.c | 2 +- arch/arm/mach-davinci/dm365.c | 2 +- arch/arm/mach-davinci/dm644x.c | 2 +- arch/arm/mach-davinci/dm646x.c | 2 +- 12 files changed, 134 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-davinci/board-da830-evm.c b/arch/arm/mach-davinci/board-da830-evm.c index dc19870..54e8567 100644 --- a/arch/arm/mach-davinci/board-da830-evm.c +++ b/arch/arm/mach-davinci/board-da830-evm.c @@ -20,9 +20,11 @@ #include <linux/i2c/at24.h> #include <linux/mtd/mtd.h> #include <linux/mtd/partitions.h> +#include <linux/clk.h> #include <asm/mach-types.h> #include <asm/mach/arch.h> +#include <mach/clock.h> #include <mach/cp_intc.h> #include <mach/mux.h> @@ -30,6 +32,8 @@ #include <mach/da8xx.h> #include <mach/usb.h> +#include "clock.h" + #define DA830_EVM_PHY_MASK 0x0 #define DA830_EVM_MDIO_FREQUENCY 2200000 /* PHY bus frequency */ @@ -557,9 +561,24 @@ static __init void da830_evm_irq_init(void) soc_info->intc_irq_prios); } +#define EMAC_PHY_CLK_RATE 50000000 + +static struct clk emac_phy = { + .name = "emac_phy", + .rate = EMAC_PHY_CLK_RATE, +}; + +static struct clk_lookup emac_phy_clks[] = { + CLK("davinci_emac.1", "phy_clk", &emac_phy), + CLK(NULL, NULL, NULL), +}; + static void __init da830_evm_map_io(void) { da830_init(); + + clkdev_add(emac_phy_clks); + clk_register(&emac_phy); } MACHINE_START(DAVINCI_DA830_EVM, "DaVinci DA830/OMAP-L137 EVM") diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c index 411284d..c43ae45 100644 --- a/arch/arm/mach-davinci/board-da850-evm.c +++ b/arch/arm/mach-davinci/board-da850-evm.c @@ -24,6 +24,7 @@ #include <linux/mtd/partitions.h> #include <linux/mtd/physmap.h> #include <linux/regulator/machine.h> +#include <linux/clk.h> #include <asm/mach-types.h> #include <asm/mach/arch.h> @@ -32,6 +33,9 @@ #include <mach/da8xx.h> #include <mach/nand.h> #include <mach/mux.h> +#include <mach/clock.h> + +#include "clock.h" #define DA850_EVM_PHY_MASK 0x1 #define DA850_EVM_MDIO_FREQUENCY 2200000 /* PHY bus frequency */ @@ -551,6 +555,18 @@ static const short da850_evm_lcdc_pins[] = { -1 }; +#define EMAC_MII_PHY_CLK_RATE 25000000 +#define EMAC_RMII_PHY_CLK_RATE 50000000 + +static struct clk emac_phy = { + .name = "emac_phy", +}; + +static struct clk_lookup emac_phy_clks[] = { + CLK("davinci_emac.1", "phy_clk", &emac_phy), + CLK(NULL, NULL, NULL), +}; + static int __init da850_evm_config_emac(void) { void __iomem *cfg_chip3_base; @@ -571,17 +587,22 @@ static int __init da850_evm_config_emac(void) ret = da8xx_pinmux_setup(da850_rmii_pins); pr_info("EMAC: RMII PHY configured, MII PHY will not be" " functional\n"); + emac_phy.rate = EMAC_RMII_PHY_CLK_RATE; } else { val &= ~BIT(8); ret = da8xx_pinmux_setup(da850_cpgmac_pins); pr_info("EMAC: MII PHY configured, RMII PHY will not be" " functional\n"); + emac_phy.rate = EMAC_MII_PHY_CLK_RATE; } if (ret) pr_warning("da850_evm_init: cpgmac/rmii mux setup failed: %d\n", ret); + clkdev_add(emac_phy_clks); + clk_register(&emac_phy); + /* configure the CFGCHIP3 register for RMII or MII */ __raw_writel(val, cfg_chip3_base); diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c index d15bece..c36e034 100644 --- a/arch/arm/mach-davinci/board-dm365-evm.c +++ b/arch/arm/mach-davinci/board-dm365-evm.c @@ -38,9 +38,12 @@ #include <mach/mmc.h> #include <mach/nand.h> #include <mach/keyscan.h> +#include <mach/clock.h> #include <media/tvp514x.h> +#include "clock.h" + static inline int have_imager(void) { /* REVISIT when it's supported, trigger via Kconfig */ @@ -566,11 +569,26 @@ static struct davinci_uart_config uart_config __initdata = { .enabled_uarts = (1 << 0), }; +#define EMAC_PHY_CLK_RATE 25000000 + +static struct clk emac_phy = { + .name = "emac_phy", + .rate = EMAC_PHY_CLK_RATE, +}; + +static struct clk_lookup emac_phy_clks[] = { + CLK("davinci_emac.1", "phy_clk", &emac_phy), + CLK(NULL, NULL, NULL), +}; + static void __init dm365_evm_map_io(void) { /* setup input configuration for VPFE input devices */ dm365_set_vpfe_config(&vpfe_cfg); dm365_init(); + + clkdev_add(emac_phy_clks); + clk_register(&emac_phy); } static struct spi_eeprom at25640 = { diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c index 976e11b..ba90181 100644 --- a/arch/arm/mach-davinci/board-dm644x-evm.c +++ b/arch/arm/mach-davinci/board-dm644x-evm.c @@ -37,6 +37,9 @@ #include <mach/nand.h> #include <mach/mmc.h> #include <mach/usb.h> +#include <mach/clock.h> + +#include "clock.h" #define DM644X_EVM_PHY_MASK (0x2) #define DM644X_EVM_MDIO_FREQUENCY (2200000) /* PHY bus frequency */ @@ -649,12 +652,27 @@ static struct davinci_uart_config uart_config __initdata = { .enabled_uarts = (1 << 0), }; +#define EMAC_PHY_CLK_RATE 25000000 + +static struct clk emac_phy = { + .name = "emac_phy", + .rate = EMAC_PHY_CLK_RATE, +}; + +static struct clk_lookup emac_phy_clks[] = { + CLK("davinci_emac.1", "phy_clk", &emac_phy), + CLK(NULL, NULL, NULL), +}; + static void __init davinci_evm_map_io(void) { /* setup input configuration for VPFE input devices */ dm644x_set_vpfe_config(&vpfe_cfg); dm644x_init(); + + clkdev_add(emac_phy_clks); + clk_register(&emac_phy); } static int davinci_phy_fixup(struct phy_device *phydev) diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c index 5ba3cb2..6241893 100644 --- a/arch/arm/mach-davinci/board-dm646x-evm.c +++ b/arch/arm/mach-davinci/board-dm646x-evm.c @@ -711,10 +711,25 @@ static void __init cdce_clk_init(void) } } +#define EMAC_PHY_CLK_RATE 25000000 + +static struct clk emac_phy = { + .name = "emac_phy", + .rate = EMAC_PHY_CLK_RATE, +}; + +static struct clk_lookup emac_phy_clks[] = { + CLK("davinci_emac.1", "phy_clk", &emac_phy), + CLK(NULL, NULL, NULL), +}; + static void __init davinci_map_io(void) { dm646x_init(); cdce_clk_init(); + + clkdev_add(emac_phy_clks); + clk_register(&emac_phy); } static struct davinci_uart_config uart_config __initdata = { diff --git a/arch/arm/mach-davinci/board-neuros-osd2.c b/arch/arm/mach-davinci/board-neuros-osd2.c index bd9ca07..075962c 100644 --- a/arch/arm/mach-davinci/board-neuros-osd2.c +++ b/arch/arm/mach-davinci/board-neuros-osd2.c @@ -26,6 +26,7 @@ #include <linux/platform_device.h> #include <linux/gpio.h> #include <linux/mtd/partitions.h> +#include <linux/clk.h> #include <asm/mach-types.h> #include <asm/mach/arch.h> @@ -37,6 +38,9 @@ #include <mach/nand.h> #include <mach/mmc.h> #include <mach/usb.h> +#include <mach/clock.h> + +#include "clock.h" #define NEUROS_OSD2_PHY_MASK 0x2 #define NEUROS_OSD2_MDIO_FREQUENCY 2200000 /* PHY bus frequency */ @@ -188,9 +192,24 @@ static struct davinci_uart_config uart_config __initdata = { .enabled_uarts = (1 << 0), }; +#define EMAC_PHY_CLK_RATE 25000000 + +static struct clk emac_phy = { + .name = "emac_phy", + .rate = EMAC_PHY_CLK_RATE, +}; + +static struct clk_lookup emac_phy_clks[] = { + CLK("davinci_emac.1", "phy_clk", &emac_phy), + CLK(NULL, NULL, NULL), +}; + static void __init davinci_ntosd2_map_io(void) { dm644x_init(); + + clkdev_add(emac_phy_clks); + clk_register(&emac_phy); } /* diff --git a/arch/arm/mach-davinci/board-sffsdr.c b/arch/arm/mach-davinci/board-sffsdr.c index 08d373b..7faa6cf 100644 --- a/arch/arm/mach-davinci/board-sffsdr.c +++ b/arch/arm/mach-davinci/board-sffsdr.c @@ -30,6 +30,7 @@ #include <linux/mtd/mtd.h> #include <linux/mtd/nand.h> #include <linux/mtd/partitions.h> +#include <linux/clk.h> #include <asm/mach-types.h> #include <asm/mach/arch.h> @@ -41,6 +42,9 @@ #include <mach/serial.h> #include <mach/mux.h> #include <mach/usb.h> +#include <mach/clock.h> + +#include "clock.h" #define SFFSDR_PHY_MASK (0x2) #define SFFSDR_MDIO_FREQUENCY (2200000) /* PHY bus frequency */ @@ -133,9 +137,24 @@ static struct davinci_uart_config uart_config __initdata = { .enabled_uarts = (1 << 0), }; +#define EMAC_PHY_CLK_RATE 25000000 + +static struct clk emac_phy = { + .name = "emac_phy", + .rate = EMAC_PHY_CLK_RATE, +}; + +static struct clk_lookup emac_phy_clks[] = { + CLK("davinci_emac.1", "phy_clk", &emac_phy), + CLK(NULL, NULL, NULL), +}; + static void __init davinci_sffsdr_map_io(void) { dm644x_init(); + + clkdev_add(emac_phy_clks); + clk_register(&emac_phy); } static __init void davinci_sffsdr_init(void) diff --git a/arch/arm/mach-davinci/da830.c b/arch/arm/mach-davinci/da830.c index 122e61a..31903e2 100644 --- a/arch/arm/mach-davinci/da830.c +++ b/arch/arm/mach-davinci/da830.c @@ -414,7 +414,7 @@ static struct clk_lookup da830_clks[] = { CLK(NULL, "aemif", &aemif_clk), CLK(NULL, "aintc", &aintc_clk), CLK(NULL, "secu_mgr", &secu_mgr_clk), - CLK("davinci_emac.1", NULL, &emac_clk), + CLK("davinci_emac.1", "emac_clk", &emac_clk), CLK(NULL, "gpio", &gpio_clk), CLK("i2c_davinci.2", NULL, &i2c1_clk), CLK(NULL, "usb11", &usb11_clk), diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c index d0fd756..4fd92d9 100644 --- a/arch/arm/mach-davinci/da850.c +++ b/arch/arm/mach-davinci/da850.c @@ -371,7 +371,7 @@ static struct clk_lookup da850_clks[] = { CLK(NULL, "emif3", &emif3_clk), CLK(NULL, "arm", &arm_clk), CLK(NULL, "rmii", &rmii_clk), - CLK("davinci_emac.1", NULL, &emac_clk), + CLK("davinci_emac.1", "emac_clk", &emac_clk), CLK("davinci-mcasp.0", NULL, &mcasp_clk), CLK("da8xx_lcdc.0", NULL, &lcdc_clk), CLK("davinci_mmc.0", NULL, &mmcsd_clk), diff --git a/arch/arm/mach-davinci/dm365.c b/arch/arm/mach-davinci/dm365.c index 27772e1..71f773c 100644 --- a/arch/arm/mach-davinci/dm365.c +++ b/arch/arm/mach-davinci/dm365.c @@ -457,7 +457,7 @@ static struct clk_lookup dm365_clks[] = { CLK("watchdog", NULL, &timer2_clk), CLK(NULL, "timer3", &timer3_clk), CLK(NULL, "usb", &usb_clk), - CLK("davinci_emac.1", NULL, &emac_clk), + CLK("davinci_emac.1", "emac_clk", &emac_clk), CLK("davinci_voicecodec", NULL, &voicecodec_clk), CLK("davinci-asp.0", NULL, &asp0_clk), CLK(NULL, "rto", &rto_clk), diff --git a/arch/arm/mach-davinci/dm644x.c b/arch/arm/mach-davinci/dm644x.c index 2f2ae8b..70948d4 100644 --- a/arch/arm/mach-davinci/dm644x.c +++ b/arch/arm/mach-davinci/dm644x.c @@ -299,7 +299,7 @@ struct clk_lookup dm644x_clks[] = { CLK(NULL, "uart0", &uart0_clk), CLK(NULL, "uart1", &uart1_clk), CLK(NULL, "uart2", &uart2_clk), - CLK("davinci_emac.1", NULL, &emac_clk), + CLK("davinci_emac.1", "emac_clk", &emac_clk), CLK("i2c_davinci.1", NULL, &i2c_clk), CLK("palm_bk3710", NULL, &ide_clk), CLK("davinci-asp", NULL, &asp_clk), diff --git a/arch/arm/mach-davinci/dm646x.c b/arch/arm/mach-davinci/dm646x.c index 893baf4..464cebc 100644 --- a/arch/arm/mach-davinci/dm646x.c +++ b/arch/arm/mach-davinci/dm646x.c @@ -342,7 +342,7 @@ struct clk_lookup dm646x_clks[] = { CLK("davinci-mcasp.0", NULL, &mcasp0_clk), CLK("davinci-mcasp.1", NULL, &mcasp1_clk), CLK(NULL, "aemif", &aemif_clk), - CLK("davinci_emac.1", NULL, &emac_clk), + CLK("davinci_emac.1", "emac_clk", &emac_clk), CLK(NULL, "pwm0", &pwm0_clk), CLK(NULL, "pwm1", &pwm1_clk), CLK(NULL, "timer0", &timer0_clk), -- 1.6.2.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] davinci: introduce EMAC PHY clock usage 2010-03-11 14:24 ` [PATCH 2/2] davinci: introduce EMAC PHY clock usage Sriramakrishnan @ 2010-03-12 22:38 ` Kevin Hilman 2010-03-15 14:59 ` Nori, Sekhar 0 siblings, 1 reply; 7+ messages in thread From: Kevin Hilman @ 2010-03-12 22:38 UTC (permalink / raw) To: Sriramakrishnan; +Cc: netdev, davinci-linux-open-source Sriramakrishnan <srk@ti.com> writes: > From: Sekhar Nori <nsekhar@ti.com> > > The patch "TI DaVinci EMAC: Add EMAC PHY clock handling" adds > support for enabling and disabling the EMAC PHY clock. > > The PHY clock on all DaVinci boards is derived from a fixed > on board clock. This patch adds the PHY clock definition to > the clock tree for all the DaVinci boards using EMAC. Also, > the existing input to EMAC module is differentiated from the > PHY clock using the clock name "emac_clk". > > Without this patch ethernet fails to initialize since it cannot > get the PHY clock and EMAC clock. > > Tested on EVM boards for DM365, DM6467, DM644x, DA830 and DA850. > > Signed-off-by: Sekhar Nori <nsekhar@ti.com> > --- > Though i have made changes for Neuros OSD2 and SFFSDR boards, i > do not have the hardware to test. Appreciate if folks having this > hardware ack the patch. > > arch/arm/mach-davinci/board-da830-evm.c | 19 +++++++++++++++++++ > arch/arm/mach-davinci/board-da850-evm.c | 21 +++++++++++++++++++++ > arch/arm/mach-davinci/board-dm365-evm.c | 18 ++++++++++++++++++ > arch/arm/mach-davinci/board-dm644x-evm.c | 18 ++++++++++++++++++ > arch/arm/mach-davinci/board-dm646x-evm.c | 15 +++++++++++++++ > arch/arm/mach-davinci/board-neuros-osd2.c | 19 +++++++++++++++++++ > arch/arm/mach-davinci/board-sffsdr.c | 19 +++++++++++++++++++ > arch/arm/mach-davinci/da830.c | 2 +- > arch/arm/mach-davinci/da850.c | 2 +- > arch/arm/mach-davinci/dm365.c | 2 +- > arch/arm/mach-davinci/dm644x.c | 2 +- > arch/arm/mach-davinci/dm646x.c | 2 +- > 12 files changed, 134 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-davinci/board-da830-evm.c b/arch/arm/mach-davinci/board-da830-evm.c > index dc19870..54e8567 100644 > --- a/arch/arm/mach-davinci/board-da830-evm.c > +++ b/arch/arm/mach-davinci/board-da830-evm.c > @@ -20,9 +20,11 @@ > #include <linux/i2c/at24.h> > #include <linux/mtd/mtd.h> > #include <linux/mtd/partitions.h> > +#include <linux/clk.h> > > #include <asm/mach-types.h> > #include <asm/mach/arch.h> > +#include <mach/clock.h> > > #include <mach/cp_intc.h> > #include <mach/mux.h> > @@ -30,6 +32,8 @@ > #include <mach/da8xx.h> > #include <mach/usb.h> > > +#include "clock.h" > + > #define DA830_EVM_PHY_MASK 0x0 > #define DA830_EVM_MDIO_FREQUENCY 2200000 /* PHY bus frequency */ > > @@ -557,9 +561,24 @@ static __init void da830_evm_irq_init(void) > soc_info->intc_irq_prios); > } > > +#define EMAC_PHY_CLK_RATE 50000000 > + > +static struct clk emac_phy = { > + .name = "emac_phy", > + .rate = EMAC_PHY_CLK_RATE, > +}; > + > +static struct clk_lookup emac_phy_clks[] = { > + CLK("davinci_emac.1", "phy_clk", &emac_phy), Just make it "phy" instead of "phy_clk". The con_id field is just a handle to differentiate between multiple clocks per device. The same for the emac_clk change. I'd call that one "main" (or "emac" if you prefer.) Doing this change will require an update do PATCH 1/2 as well. > + CLK(NULL, NULL, NULL), > +}; > + I'm not crazy about the clock definitions in the board files. I assume you put it here instead of <soc>.c is because each clock has a board specific rate. Instead, what I'd rather see is the clock defined once for each <soc>.c with a custom set_rate hook. The default rate could be a per-SoC default (25MHz looks common) and any board files that don't use the default can use clk_set_rate() to change it. This approach should simplfy things and minimize changes to board files. Kevin ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 2/2] davinci: introduce EMAC PHY clock usage 2010-03-12 22:38 ` Kevin Hilman @ 2010-03-15 14:59 ` Nori, Sekhar 0 siblings, 0 replies; 7+ messages in thread From: Nori, Sekhar @ 2010-03-15 14:59 UTC (permalink / raw) To: Kevin Hilman Cc: netdev@vger.kernel.org, davinci-linux-open-source@linux.davincidsp.com, Govindarajan, Sriramakrishnan On Sat, Mar 13, 2010 at 04:08:20, Kevin Hilman wrote: > Sriramakrishnan <srk@ti.com> writes: > > > From: Sekhar Nori <nsekhar@ti.com> > > > > The patch "TI DaVinci EMAC: Add EMAC PHY clock handling" adds > > support for enabling and disabling the EMAC PHY clock. > > > > The PHY clock on all DaVinci boards is derived from a fixed > > on board clock. This patch adds the PHY clock definition to > > the clock tree for all the DaVinci boards using EMAC. Also, > > the existing input to EMAC module is differentiated from the > > PHY clock using the clock name "emac_clk". > > > > Without this patch ethernet fails to initialize since it cannot > > get the PHY clock and EMAC clock. > > > > Tested on EVM boards for DM365, DM6467, DM644x, DA830 and DA850. > > > > Signed-off-by: Sekhar Nori <nsekhar@ti.com> [...] > > > > +#define EMAC_PHY_CLK_RATE 50000000 > > + > > +static struct clk emac_phy = { > > + .name = "emac_phy", > > + .rate = EMAC_PHY_CLK_RATE, > > +}; > > + > > +static struct clk_lookup emac_phy_clks[] = { > > + CLK("davinci_emac.1", "phy_clk", &emac_phy), > [...] > > > + CLK(NULL, NULL, NULL), > > +}; > > + > > I'm not crazy about the clock definitions in the board files. I > assume you put it here instead of <soc>.c is because each clock > has a board specific rate. That and the fact that none of the DaVinci devices have an integrated PHY on the SoC. The clock comes from an onboard oscillator too. So, it seemed odd to include phy clock structure in the SoC specific file. > > Instead, what I'd rather see is the clock defined once for each > <soc>.c with a custom set_rate hook. The default rate could > be a per-SoC default (25MHz looks common) and any board files > that don't use the default can use clk_set_rate() to change it. > > This approach should simplfy things and minimize changes to board > files. Right, that surely will lead to a much simpler patch so I will go ahead and change. Also, only DA850 offers a choice between MII (25MHz) and RMII (50MHz) phy. So, the set_rate needs to be implemented only for this SoC. Thanks, Sekhar ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] TI DaVinci EMAC: Add EMAC PHY clock handling. [not found] ` <1268317491-3822-2-git-send-email-srk-l0cyMroinI0@public.gmane.org> 2010-03-11 14:24 ` [PATCH 2/2] davinci: introduce EMAC PHY clock usage Sriramakrishnan @ 2010-03-12 22:27 ` Kevin Hilman 2010-03-12 22:33 ` David Miller 1 sibling, 1 reply; 7+ messages in thread From: Kevin Hilman @ 2010-03-12 22:27 UTC (permalink / raw) To: David S. Miller, Sriramakrishnan Cc: netdev-u79uwXL29TY76Z2rM5mHXA, davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/ Sriramakrishnan <srk-l0cyMroinI0@public.gmane.org> writes: > Source for the EMAC PHY clock can be different from the > module clock and driver needs to request/enable the EMAC > phy clock explicitly. This was not required earlier as on > most Davinci platforms the phy clock is always on . On AM35x > platform the phy clock needs to be managed explicitly , hence > adding clock management for phy clock. > > Signed-off-by: Sriramakrishnan <srk-l0cyMroinI0@public.gmane.org> Acked-by: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org> Dave, if you prefer, with your ack, I'll merge this via the davinci tree along with corresponding platform changes. Kevin > --- > drivers/net/davinci_emac.c | 22 ++++++++++++++++++++-- > 1 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c > index 8a42dbe..d9ae6ee 100644 > --- a/drivers/net/davinci_emac.c > +++ b/drivers/net/davinci_emac.c > @@ -491,6 +491,7 @@ struct emac_priv { > > /* clock frequency for EMAC */ > static struct clk *emac_clk; > +static struct clk *emac_phy_clk; > static unsigned long emac_bus_frequency; > static unsigned long mdio_max_freq; > > @@ -2637,18 +2638,28 @@ static int __devinit davinci_emac_probe(struct platform_device *pdev) > struct emac_platform_data *pdata; > struct device *emac_dev; > > - /* obtain emac clock from kernel */ > - emac_clk = clk_get(&pdev->dev, NULL); > + /* obtain emac module clock from kernel */ > + emac_clk = clk_get(&pdev->dev, "emac_clk"); > if (IS_ERR(emac_clk)) { > printk(KERN_ERR "DaVinci EMAC: Failed to get EMAC clock\n"); > return -EBUSY; > } > + > + /* obtain emac phy clock from kernel */ > + emac_phy_clk = clk_get(&pdev->dev, "phy_clk"); > + if (IS_ERR(emac_phy_clk)) { > + printk(KERN_ERR "DaVinci EMAC: Failed to get PHY clock\n"); > + clk_put(emac_clk); > + return -EBUSY; > + } > + > emac_bus_frequency = clk_get_rate(emac_clk); > /* TODO: Probe PHY here if possible */ > > ndev = alloc_etherdev(sizeof(struct emac_priv)); > if (!ndev) { > printk(KERN_ERR "DaVinci EMAC: Error allocating net_device\n"); > + clk_put(emac_phy_clk); > clk_put(emac_clk); > return -ENOMEM; > } > @@ -2734,6 +2745,7 @@ static int __devinit davinci_emac_probe(struct platform_device *pdev) > netif_napi_add(ndev, &priv->napi, emac_poll, EMAC_POLL_WEIGHT); > > clk_enable(emac_clk); > + clk_enable(emac_phy_clk); > > /* register the network device */ > SET_NETDEV_DEV(ndev, &pdev->dev); > @@ -2783,6 +2795,7 @@ mdiobus_quit: > > netdev_reg_err: > mdio_alloc_err: > + clk_disable(emac_phy_clk); > clk_disable(emac_clk); > no_irq_res: > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > @@ -2790,6 +2803,7 @@ no_irq_res: > iounmap(priv->remap_addr); > > probe_quit: > + clk_put(emac_phy_clk); > clk_put(emac_clk); > free_netdev(ndev); > return rc; > @@ -2821,7 +2835,9 @@ static int __devexit davinci_emac_remove(struct platform_device *pdev) > free_netdev(ndev); > iounmap(priv->remap_addr); > > + clk_disable(emac_phy_clk); > clk_disable(emac_clk); > + clk_put(emac_phy_clk); > clk_put(emac_clk); > > return 0; > @@ -2835,6 +2851,7 @@ static int davinci_emac_suspend(struct device *dev) > if (netif_running(ndev)) > emac_dev_stop(ndev); > > + clk_disable(emac_phy_clk); > clk_disable(emac_clk); > > return 0; > @@ -2846,6 +2863,7 @@ static int davinci_emac_resume(struct device *dev) > struct net_device *ndev = platform_get_drvdata(pdev); > > clk_enable(emac_clk); > + clk_enable(emac_phy_clk); > > if (netif_running(ndev)) > emac_dev_open(ndev); > -- > 1.6.2.4 > > _______________________________________________ > Davinci-linux-open-source mailing list > Davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org > http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] TI DaVinci EMAC: Add EMAC PHY clock handling. 2010-03-12 22:27 ` [PATCH 1/2] TI DaVinci EMAC: Add EMAC PHY clock handling Kevin Hilman @ 2010-03-12 22:33 ` David Miller 0 siblings, 0 replies; 7+ messages in thread From: David Miller @ 2010-03-12 22:33 UTC (permalink / raw) To: khilman; +Cc: srk, netdev, davinci-linux-open-source From: Kevin Hilman <khilman@deeprootsystems.com> Date: Fri, 12 Mar 2010 14:27:09 -0800 > Sriramakrishnan <srk@ti.com> writes: > >> Source for the EMAC PHY clock can be different from the >> module clock and driver needs to request/enable the EMAC >> phy clock explicitly. This was not required earlier as on >> most Davinci platforms the phy clock is always on . On AM35x >> platform the phy clock needs to be managed explicitly , hence >> adding clock management for phy clock. >> >> Signed-off-by: Sriramakrishnan <srk@ti.com> > > Acked-by: Kevin Hilman <khilman@deeprootsystems.com> > > Dave, if you prefer, with your ack, I'll merge this via the davinci > tree along with corresponding platform changes. Please do: Acked-by: David S. Miller <davem@davemloft.net> ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-03-15 15:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-11 14:24 [PATCH 0/2] TI DaVinci EMAC: Add support for handling PHY Clock Sriramakrishnan
2010-03-11 14:24 ` [PATCH 1/2] TI DaVinci EMAC: Add EMAC PHY clock handling Sriramakrishnan
[not found] ` <1268317491-3822-2-git-send-email-srk-l0cyMroinI0@public.gmane.org>
2010-03-11 14:24 ` [PATCH 2/2] davinci: introduce EMAC PHY clock usage Sriramakrishnan
2010-03-12 22:38 ` Kevin Hilman
2010-03-15 14:59 ` Nori, Sekhar
2010-03-12 22:27 ` [PATCH 1/2] TI DaVinci EMAC: Add EMAC PHY clock handling Kevin Hilman
2010-03-12 22:33 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).