From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael Chan" Subject: Re: BNX2: Kernel crashes with 2.6.31 and 2.6.31.9 Date: Thu, 11 Mar 2010 10:38:58 -0800 Message-ID: <1268332738.9775.133.camel@nseg_linux_HP1.broadcom.com> References: <1268263973.9775.95.camel@nseg_linux_HP1.broadcom.com> <4B9850DC.9060703@hp.com> <1268329796.9775.125.camel@nseg_linux_HP1.broadcom.com> <20100311.100519.124285161.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "brian.haley@hp.com" , "bonbons@linux-vserver.org" , "Benjamin Li" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: "David Miller" Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:1529 "EHLO MMS3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757990Ab0CKSui (ORCPT ); Thu, 11 Mar 2010 13:50:38 -0500 In-Reply-To: <20100311.100519.124285161.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 2010-03-11 at 10:05 -0800, David Miller wrote: > From: "Michael Chan" > Date: Thu, 11 Mar 2010 09:49:56 -0800 > > > > > On Wed, 2010-03-10 at 18:09 -0800, Brian Haley wrote: > >> >> I'm able to cause a netdev_watchdog timeout by changing the coalesce > >> >> settings on my bnx2, I built a little test program for it: > >> > > >> > Do you run this program in a loop? How quickly do you see the NETDEV > >> > WATCHDOG? > >> > >> It's run once, and we see it almost immediately after ETHTOOL_SCOALESCE. > > > > What's the difference between running the test program and doing ethtool > > -C? Do you see the issue in either case? I don't see the issue here > > with ethtool -C. > > Probably because the independent program runs faster and thus > can trigger races more easily. > That's what I thought, I thought he was running it in a loop and triggering some race condition. But he said he only ran it once. His program gets the coalesce settings, sleeps for 5 seconds, and then sets the coalesce settings. > In any case, you should be trying to reproduce his problem with > his test program since he went through the effort of providing > one. > I just tried it and cannot reproduce the problem. Brian, please provide more information. Thanks.