From: Ben Hutchings <bhutchings@solarflare.com>
To: Ajit Khaparde <ajitk@serverengines.com>
Cc: David Miller <davem@davemloft.net>,
jeff@garzik.org, netdev <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH net-2.6] net/ethtool: add multiple queue support to {get,set}_ringparams
Date: Sun, 14 Mar 2010 04:21:57 +0000 [thread overview]
Message-ID: <1268540517.2664.51.camel@localhost> (raw)
In-Reply-To: <20100314014335.GA17208@serverengines.com>
On Sun, 2010-03-14 at 07:13 +0530, Ajit Khaparde wrote:
> With network devices and hence device drivers supporting
> multiple Tx and Rx rings, currently there is no way for
> ethtool to specify which Tx/Rx ring the user wants to get/set.
> This patch enhances the {get,set}_ringparams by allowing
> the user to specify the Tx/Rx ring id of interest.
> Please review.
[...]
So long as queue selection is done using a hash of the flow parameters,
there is no sense in setting different sizes for different queues. If
drivers use additional queues that are not selected in this way and
which may require different sizes, that information also needs to be
exposed through ethtool (and perhaps to the networking core).
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2010-03-14 4:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 1:43 [RFC PATCH net-2.6] net/ethtool: add multiple queue support to {get,set}_ringparams Ajit Khaparde
2010-03-14 2:11 ` David Miller
2010-03-14 16:17 ` [PATCH] ethtool.h: Add "structs are public" disclaimer comment Joe Perches
2010-03-14 17:50 ` Ben Hutchings
2010-03-14 18:38 ` Jeff Garzik
2010-03-14 22:08 ` David Miller
2010-03-14 4:21 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268540517.2664.51.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=ajitk@serverengines.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).