* Re: [3/3] gigaset: prune use of tty_buffer_request_room
@ 2010-03-15 14:48 Karsten Keil
0 siblings, 0 replies; only message in thread
From: Karsten Keil @ 2010-03-15 14:48 UTC (permalink / raw)
To: Tilman Schmidt
Cc: David Miller, netdev, linux-kernel, stable, isdn4linux,
Hansjoerg Lipp, i4ldeveloper, Alan Cox
Calling tty_buffer_request_room() before tty_insert_flip_string()
is unnecessary, costs CPU and for big buffers can mess up the
multi-page allocation avoidance.
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Acked-by: Karsten Keil <keil@b1-systems.de>
---
Note to -stable: applies correctly to 2.6.33 with fuzz 2.
drivers/isdn/gigaset/interface.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c
index a1bcbc2..f0dc6c9 100644
--- a/drivers/isdn/gigaset/interface.c
+++ b/drivers/isdn/gigaset/interface.c
@@ -628,7 +628,6 @@ void gigaset_if_receive(struct cardstate *cs,
if (tty == NULL)
gig_dbg(DEBUG_IF, "receive on closed device");
else {
- tty_buffer_request_room(tty, len);
tty_insert_flip_string(tty, buffer, len);
tty_flip_buffer_push(tty);
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-03-15 14:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-15 14:48 [3/3] gigaset: prune use of tty_buffer_request_room Karsten Keil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).