From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karsten Keil Subject: Re: [3/3] gigaset: prune use of tty_buffer_request_room Date: Mon, 15 Mar 2010 14:48:05 -0000 Message-ID: <1268665009.25656@pingi> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, isdn4linux , Hansjoerg Lipp , i4ldeveloper , Alan Cox To: Tilman Schmidt Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Calling tty_buffer_request_room() before tty_insert_flip_string() is unnecessary, costs CPU and for big buffers can mess up the multi-page allocation avoidance. Signed-off-by: Tilman Schmidt Acked-by: Karsten Keil --- Note to -stable: applies correctly to 2.6.33 with fuzz 2. drivers/isdn/gigaset/interface.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c index a1bcbc2..f0dc6c9 100644 --- a/drivers/isdn/gigaset/interface.c +++ b/drivers/isdn/gigaset/interface.c @@ -628,7 +628,6 @@ void gigaset_if_receive(struct cardstate *cs, if (tty == NULL) gig_dbg(DEBUG_IF, "receive on closed device"); else { - tty_buffer_request_room(tty, len); tty_insert_flip_string(tty, buffer, len); tty_flip_buffer_push(tty); }