netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: sjur.brandeland@stericsson.com
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	daniel.martensson@stericsson.com, kaber@trash.net,
	stefano.babic@babic.homelinux.org, randy.dunlap@oracle.com
Subject: Re: [PATCH net-next-2.6 v6 08/12] net-caif: add CAIF socket implementation
Date: Mon, 15 Mar 2010 14:53:51 -0700	[thread overview]
Message-ID: <1268690031.2700.9.camel@localhost.localdomain> (raw)
In-Reply-To: <1267445559-1911-9-git-send-email-sjur.brandeland@stericsson.com>

Hi Sjur,

> +	/*
> +	 * The sock->type specifies the socket type to use. The CAIF socket is
> +	 * a packet stream in the sence that it is packet based.
> +	 * CAIF trusts the reliability of the link, no resending is implemented.
> +	 */
> +	if (sock->type != SOCK_SEQPACKET)
> +		return -ESOCKTNOSUPPORT;

we came to an interesting detail here when testing with a STE modem. Why
is this SEQPACKET and not a STREAM. Especially with the AT command
channels it is kinda weird that you have an MTU. The AT specification
doesn't really have any defined behavior when using a sequential packet
transport. It is more a stream based socket.

Regards

Marcel



  parent reply	other threads:[~2010-03-15 21:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-01 12:12 [PATCH net-next-2.6 v6 00/12] net-caif: introducing CAIF protocol stack sjur.brandeland
2010-03-01 12:12 ` [PATCH net-next-2.6 v6 01/12] net-caif: add CAIF protocol definitions sjur.brandeland
2010-03-01 12:12   ` [PATCH net-next-2.6 v6 02/12] net-caif: add CAIF socket and configuration headers sjur.brandeland
2010-03-01 12:12     ` [PATCH net-next-2.6 v6 03/12] net-caif: add CAIF core protocol stack header files sjur.brandeland
2010-03-01 12:12       ` [PATCH net-next-2.6 v6 04/12] net-caif: add CAIF Link layer device " sjur.brandeland
2010-03-01 12:12         ` [PATCH net-next-2.6 v6 05/12] net-caif: add CAIF core protocol stack sjur.brandeland
2010-03-01 12:12           ` [PATCH net-next-2.6 v6 06/12] net-caif: add CAIF generic caif support functions sjur.brandeland
2010-03-01 12:12             ` [PATCH net-next-2.6 v6 07/12] net-caif: add CAIF device registration functionality sjur.brandeland
2010-03-01 12:12               ` [PATCH net-next-2.6 v6 08/12] net-caif: add CAIF socket implementation sjur.brandeland
2010-03-01 12:12                 ` [PATCH net-next-2.6 v6 09/12] net-caif: add CAIF netdevice sjur.brandeland
2010-03-01 12:12                   ` [PATCH net-next-2.6 v6 10/12] net-caif: add CAIF Kconfig and Makefiles sjur.brandeland
2010-03-01 12:12                     ` [PATCH net-next-2.6 v6 11/12] net-caif: add CAIF documentation sjur.brandeland
2010-03-01 12:12                       ` [PATCH net-next-2.6 v6 12/12] net-caif-driver: add CAIF serial driver (ldisc) sjur.brandeland
2010-03-15 21:53                 ` Marcel Holtmann [this message]
2010-03-16 13:27                   ` [PATCH net-next-2.6 v6 08/12] net-caif: add CAIF socket implementation Sjur Brændeland
2010-03-17  6:03                     ` Marcel Holtmann
2010-03-17 11:04                       ` Sjur BRENDELAND
2010-03-03  9:17 ` [PATCH net-next-2.6 v6 00/12] net-caif: introducing CAIF protocol stack David Miller
2010-03-03 14:10   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268690031.2700.9.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=daniel.martensson@stericsson.com \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sjur.brandeland@stericsson.com \
    --cc=stefano.babic@babic.homelinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).