public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Robert Olsson <robert@herjulf.net>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] pktgen node allocation
Date: Fri, 19 Mar 2010 10:28:53 +0100	[thread overview]
Message-ID: <1268990933.3048.15.camel@edumazet-laptop> (raw)
In-Reply-To: <19363.14702.909265.380669@gargle.gargle.HOWL>

Le vendredi 19 mars 2010 à 09:44 +0100, Robert Olsson a écrit :
> 
> Hi,
> Here is patch to manipulate packet node allocation and implicitly 
> how packets are DMA'd etc.
> 
> The flag NODE_ALLOC enables the function and numa_node_id();
> when enabled it can also be explicitly controlled via a new 
> node parameter
> 
> Tested this with 10 Intel 82599 ports w. TYAN S7025 E5520 CPU's.
> Was able to TX/DMA ~80 Gbit/s to Ethernet wires.
> 
> Cheers
> 					--ro
> 

I cannot understand how this can help.

__netdev_alloc_skb() is supposed to already take into account NUMA
properties :

int node = dev->dev.parent ? dev_to_node(dev->dev.parent) : -1;

If this doesnt work, we should correct core stack, not only pktgen :)

Are you allocating memory in the node where pktgen CPU is running or the
node close to the NIC ?


Thanks



  reply	other threads:[~2010-03-19  9:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-19  8:44 [PATCH] pktgen node allocation Robert Olsson
2010-03-19  9:28 ` Eric Dumazet [this message]
2010-03-19 13:35   ` robert
2010-03-19 13:47     ` Eric Dumazet
2010-03-22  6:24       ` Robert Olsson
2010-03-22  7:43         ` Eric Dumazet
2010-03-22 18:05           ` Robert Olsson
2010-03-22  3:37     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268990933.3048.15.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=robert@herjulf.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox