From: Matt Mackall <mpm@selenic.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Amerigo Wang <amwang@redhat.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [Patch] netconsole: do not depend on experimental
Date: Mon, 22 Mar 2010 17:17:43 -0500 [thread overview]
Message-ID: <1269296263.3552.5.camel@calx> (raw)
In-Reply-To: <20100322125919.GB4288@hmsreliant.think-freely.org>
On Mon, 2010-03-22 at 08:59 -0400, Neil Horman wrote:
> On Mon, Mar 22, 2010 at 05:59:23AM -0400, Amerigo Wang wrote:
> >
> > Nowadays, most distributions enable netconsole by default,
> > including RHEL, Fedora, Debian, Arch, Opensuse. And
> > we don't have any bug reports about it. So I think there
> > is no need to mark it as experimental any more.
> >
> > Cc: David S. Miller <davem@davemloft.net>
> > Signed-off-by: WANG Cong <amwang@redhat.com>
> >
> > ---
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index 0ba5b8e..e3d6c52 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -3252,15 +3252,14 @@ config NET_FC
> > "SCSI generic support".
> >
> > config NETCONSOLE
> > - tristate "Network console logging support (EXPERIMENTAL)"
> > - depends on EXPERIMENTAL
> > + tristate "Network console logging support"
> > ---help---
> > If you want to log kernel messages over the network, enable this.
> > See <file:Documentation/networking/netconsole.txt> for details.
> >
> > config NETCONSOLE_DYNAMIC
> > - bool "Dynamic reconfiguration of logging targets (EXPERIMENTAL)"
> > - depends on NETCONSOLE && SYSFS && EXPERIMENTAL
> > + bool "Dynamic reconfiguration of logging targets"
> > + depends on NETCONSOLE && SYSFS
> > select CONFIGFS_FS
> > help
> > This option enables the ability to dynamically reconfigure target
> > --
>
> Seems reasonable. Netconsole seems pretty mature.
>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Yeah, I'd forgotten that flag was even there.
Acked-by: Matt Mackall <mpm@selenic.com>
--
http://selenic.com : development and support for Mercurial and Linux
next prev parent reply other threads:[~2010-03-22 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 9:59 [Patch] netconsole: do not depend on experimental Amerigo Wang
2010-03-22 12:59 ` Neil Horman
2010-03-22 22:17 ` Matt Mackall [this message]
2010-03-23 1:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269296263.3552.5.camel@calx \
--to=mpm@selenic.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).