netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	bridge@lists.linux-foundation.org,
	Andy Gospodarek <gospo@redhat.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	Stephen Hemminger <shemminger@linux-foundation.org>,
	bonding-devel@lists.sourceforge.net,
	Jay Vosburgh <fubar@us.ibm.com>,
	David Miller <davem@davemloft.net>
Subject: Re: [RFC Patch 2/3] bridge: make bridge support netpoll
Date: Mon, 22 Mar 2010 17:35:07 -0500	[thread overview]
Message-ID: <1269297307.3552.23.camel@calx> (raw)
In-Reply-To: <20100322082112.4967.5504.sendpatchset@localhost.localdomain>

On Mon, 2010-03-22 at 04:17 -0400, Amerigo Wang wrote:
> Based on the previous patch, make bridge support netpoll by:
> 
> 1) implement the 4 methods to support netpoll for bridge;
> 
> 2) modify netpoll during forwarding packets in bridge;
> 
> 3) disable netpoll support of bridge when a netpoll-unabled device
>    is added to bridge;

Not sure if this is the right thing to do. Shouldn't we simply enable
polling on all devices that support it and warn about the others (aka
best effort)?

-- 
http://selenic.com : development and support for Mercurial and Linux

  reply	other threads:[~2010-03-22 22:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-22  8:17 [RFC Patch 1/3] netpoll: add generic support for bridge and bonding devices Amerigo Wang
2010-03-22  8:17 ` [RFC Patch 2/3] bridge: make bridge support netpoll Amerigo Wang
2010-03-22 22:35   ` Matt Mackall [this message]
2010-03-23  2:03     ` Cong Wang
2010-03-23  4:27       ` Matt Mackall
2010-03-23  4:39         ` Cong Wang
2010-03-23  4:51           ` Matt Mackall
2010-03-23  4:59             ` David Miller
2010-03-23  5:00             ` Cong Wang
2010-03-23  4:57           ` David Miller
2010-03-23  5:06             ` Cong Wang
2010-03-22  8:17 ` [RFC Patch 3/3] bonding: make bonding " Amerigo Wang
2010-03-22 22:38   ` Matt Mackall
2010-03-22 23:36     ` Jay Vosburgh
2010-03-23  2:01       ` Cong Wang
2010-03-23  0:56   ` Andy Gospodarek
2010-03-23  1:49     ` Cong Wang
2010-03-22 22:31 ` [RFC Patch 1/3] netpoll: add generic support for bridge and bonding devices Matt Mackall
2010-03-23  2:13   ` Cong Wang
2010-03-23  3:49     ` David Miller
2010-03-23  4:47       ` Cong Wang
2010-03-23  4:58         ` David Miller
2010-03-23  5:15           ` Cong Wang
2010-03-23 12:11   ` Jeff Moyer
2010-03-24  2:29     ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269297307.3552.23.camel@calx \
    --to=mpm@selenic.com \
    --cc=amwang@redhat.com \
    --cc=bonding-devel@lists.sourceforge.net \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=fubar@us.ibm.com \
    --cc=gospo@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).