netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: Cong Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	elendil@planet.nl, David Miller <davem@davemloft.net>
Subject: Re: [Patch v2] netpoll: warn when there are spaces in parameters
Date: Mon, 22 Mar 2010 23:24:16 -0500	[thread overview]
Message-ID: <1269318256.3552.49.camel@calx> (raw)
In-Reply-To: <4BA81D18.40509@redhat.com>

On Tue, 2010-03-23 at 09:44 +0800, Cong Wang wrote:
> Matt Mackall wrote:
> > On Mon, 2010-03-22 at 04:59 -0400, Amerigo Wang wrote:
> >> +			printk(KERN_INFO "%s: warning: whitespace"
> >> +					"is not allowed\n", np->name);
> > 
> > Is it a warning or is it info? If it's a warning, then we probably need
> > to add "netpoll" or whatever to the message so that people who've got a
> > warning-level threshold will know what it's about.
> > 
> 
> If you mean KERN_INFO, yeah, I want to keep it in the same level
> as other messages around.

I should probably be more direct: I think that's the wrong thing to do.
It IS a warning (it even says so!) telling users that something probably
won't work and why and they might miss it if the severity is INFO and
then come and ask us why things aren't working. So use KERN_WARN,
please.

The other messages are INFO because when things are working, they're not
interesting.

> Also, I already put "np->name" which will be "netconsole" when
> we use netconsole.

Ahh, right, I have a brain cell somewhere that knew that.

-- 
http://selenic.com : development and support for Mercurial and Linux



  reply	other threads:[~2010-03-23  4:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-22  8:59 [Patch v2] netpoll: warn when there are spaces in parameters Amerigo Wang
2010-03-22 12:30 ` Neil Horman
2010-03-23  3:06   ` David Miller
2010-03-22 22:22 ` Matt Mackall
2010-03-23  1:44   ` Cong Wang
2010-03-23  4:24     ` Matt Mackall [this message]
2010-03-23  4:34       ` Cong Wang
2010-03-23  4:45         ` Matt Mackall
2010-03-23  4:56           ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269318256.3552.49.camel@calx \
    --to=mpm@selenic.com \
    --cc=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=elendil@planet.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).