From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ulrich Drepper <drepper@gmail.com>
Cc: Brandon Black <blblack@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: behavior of recvmmsg() on blocking sockets
Date: Fri, 26 Mar 2010 15:20:10 +0100 [thread overview]
Message-ID: <1269613210.2839.75.camel@edumazet-laptop> (raw)
In-Reply-To: <a36005b51003260500v6d8b7a5av1bbba848cc8998a4@mail.gmail.com>
Le vendredi 26 mars 2010 à 05:00 -0700, Ulrich Drepper a écrit :
> On Wed, Mar 24, 2010 at 16:35, Brandon Black <blblack@gmail.com> wrote:
> > + /* MSG_WAITFORONE turns on MSG_DONTWAIT after one packet */
> > + if (!datagrams++ && flags & MSG_WAITFORONE)
> > + flags |= MSG_DONTWAIT;
>
> There should be an extra pair of parenthesis around the & operands but
> aside from that I could imagine this to work.
>
> Would be nice if the netdev folks would respond.
It seems fine, Brandon please submit a formal patch.
Thanks
next prev parent reply other threads:[~2010-03-26 14:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <84621a61003240915p2a4ce6bbjd0c6bfb02ab05ba8@mail.gmail.com>
2010-03-24 17:41 ` behavior of recvmmsg() on blocking sockets Chris Friesen
2010-03-24 18:28 ` Brandon Black
2010-03-24 18:34 ` drepper
2010-03-24 23:35 ` Brandon Black
2010-03-26 12:00 ` Ulrich Drepper
2010-03-26 14:20 ` Eric Dumazet [this message]
2010-03-24 19:36 ` Chris Friesen
2010-03-24 19:55 ` Brandon Black
2010-03-27 13:19 ` Brandon Black
2010-03-27 14:26 ` Arnaldo Carvalho de Melo
2010-03-29 16:18 ` Chris Friesen
2010-03-29 17:24 ` Brandon Black
2010-03-29 17:48 ` Chris Friesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269613210.2839.75.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=blblack@gmail.com \
--cc=drepper@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox