From: Marcel Holtmann <marcel@holtmann.org>
To: Elina Pasheva <epasheva@sierrawireless.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Rory Filer <rfiler@sierrawireless.com>,
netdev@vger.kernel.org, linux-usb <linux-usb@vger.kernel.org>
Subject: Re: [ANNOUNCEMENT] NET: usb: sierra_net.c driver
Date: Sun, 28 Mar 2010 08:57:01 -0700 [thread overview]
Message-ID: <1269791821.11714.202.camel@localhost.localdomain> (raw)
In-Reply-To: <1269652919.30630.1.camel@Linuxdev3>
Hi Elina,
> +static const struct driver_info sierra_net_info_68A3 = {
> + .description = "Sierra Wireless USB-Ethernet Modem",
> + .flags = FLAG_ETHER | FLAG_SEND_ZLP,
> + .bind = sierra_net_bind,
> + .unbind = sierra_net_unbind,
> + .status = sierra_net_status,
> + .rx_fixup = sierra_net_rx_fixup,
> + .tx_fixup = sierra_net_tx_fixup,
> + .data = (unsigned long)&sierra_net_info_data_68A3,
> +};
the FLAG_ETHER is wrong here. Please use FLAG_WWAN to clearly mark these
interfaces.
Otherwise we have wrong DEVTYPE uevent assignments and userspace will
treat them as real Ethernet cards. And that should not happen. As a nice
benefit the interface name will be wwan%d by default as well.
Regards
Marcel
next prev parent reply other threads:[~2010-03-28 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-27 1:21 [ANNOUNCEMENT] NET: usb: sierra_net.c driver Elina Pasheva
2010-03-28 10:38 ` Sergei Shtylyov
2010-03-28 15:57 ` Marcel Holtmann [this message]
[not found] ` <1269791821.11714.202.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-03-28 19:12 ` Stephen Clark
2010-03-29 0:44 ` Ben Hutchings
2010-03-29 12:30 ` Stephen Clark
[not found] ` <4BB09D75.7020500-ihVZJaRskl1bRRN4PJnoQQ@public.gmane.org>
2010-03-29 13:07 ` Ben Hutchings
[not found] ` <4BAFAA2C.8060604-ihVZJaRskl1bRRN4PJnoQQ@public.gmane.org>
2010-03-29 20:29 ` Marcel Holtmann
2010-03-29 20:41 ` David Miller
[not found] ` <20100329.134144.57458224.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-03-29 21:18 ` Elina Pasheva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269791821.11714.202.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=dbrownell@users.sourceforge.net \
--cc=epasheva@sierrawireless.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rfiler@sierrawireless.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).