From: reinette chatre <reinette.chatre@intel.com>
To: "Zhu, Yi" <yi.zhu@intel.com>
Cc: Dan Carpenter <error27@gmail.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
"Kolekar, Abhijeet" <abhijeet.kolekar@intel.com>,
"Berg, Johannes" <johannes.berg@intel.com>,
"Guy, Wey-Yi W" <wey-yi.w.guy@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] iwlwifi: range checking issue
Date: Mon, 29 Mar 2010 09:13:51 -0700 [thread overview]
Message-ID: <1269879231.2446.3410.camel@rchatre-DESK> (raw)
In-Reply-To: <1269828072.4043.247.camel@debian>
On Sun, 2010-03-28 at 19:01 -0700, Zhu, Yi wrote:
> On Sun, 2010-03-28 at 19:55 +0800, Dan Carpenter wrote:
> > IWL_RATE_COUNT is 13 and IWL_RATE_COUNT_LEGACY is 12.
> >
> > IWL_RATE_COUNT_LEGACY is the right one here because iwl3945_rates
> > doesn't support 60M and also that's how "rates" is defined in
> > iwlcore_init_geos() from drivers/net/wireless/iwlwifi/iwl-core.c.
> >
> > rates = kzalloc((sizeof(struct ieee80211_rate) * IWL_RATE_COUNT_LEGACY),
> > GFP_KERNEL);
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Acked-by: Zhu Yi <yi.zhu@intel.com>
Great catch. Since this is a fix for a buffer overflow ... could you
please pass it on to stable also?
Thank you
Reinette
prev parent reply other threads:[~2010-03-29 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-28 11:55 [patch] iwlwifi: range checking issue Dan Carpenter
2010-03-29 2:01 ` Zhu Yi
2010-03-29 16:13 ` reinette chatre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269879231.2446.3410.camel@rchatre-DESK \
--to=reinette.chatre@intel.com \
--cc=abhijeet.kolekar@intel.com \
--cc=error27@gmail.com \
--cc=ilw@linux.intel.com \
--cc=johannes.berg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox