From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Holtmann Subject: Re: [ANNOUNCEMENT] NET: usb: sierra_net.c driver Date: Mon, 29 Mar 2010 13:29:53 -0700 Message-ID: <1269894593.11714.215.camel@localhost.localdomain> References: <1269652919.30630.1.camel@Linuxdev3> <1269791821.11714.202.camel@localhost.localdomain> <4BAFAA2C.8060604@earthlink.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Elina Pasheva , David Brownell , Rory Filer , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb To: sclark46-ihVZJaRskl1bRRN4PJnoQQ@public.gmane.org Return-path: In-Reply-To: <4BAFAA2C.8060604-ihVZJaRskl1bRRN4PJnoQQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hi Stephen, > >> +static const struct driver_info sierra_net_info_68A3 = { > >> + .description = "Sierra Wireless USB-Ethernet Modem", > >> + .flags = FLAG_ETHER | FLAG_SEND_ZLP, > >> + .bind = sierra_net_bind, > >> + .unbind = sierra_net_unbind, > >> + .status = sierra_net_status, > >> + .rx_fixup = sierra_net_rx_fixup, > >> + .tx_fixup = sierra_net_tx_fixup, > >> + .data = (unsigned long)&sierra_net_info_data_68A3, > >> +}; > > > > the FLAG_ETHER is wrong here. Please use FLAG_WWAN to clearly mark these > > interfaces. > > > > Otherwise we have wrong DEVTYPE uevent assignments and userspace will > > treat them as real Ethernet cards. And that should not happen. As a nice > Why shouldn't that happen if they look like NIC cards? because they are not NIC cards. They just use Ethernet emulation. And they also require a management interface to setup APN and activate them first. It is important that we tell userspace about the type of a network interface. We do the same for WiMAX and WiFi btw. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html