From: Kim Phillips <kim.phillips@freescale.com>
To: "David S. Miller" <davem@davemloft.net>,
Anton Vorontsov <avorontsov@ru.mvista.com>,
Sandeep Gopalpet <Sandeep.Kumar@freescale.com>,
Kumar Gala <galak@kernel.crashing.org>,
Andy Flem
Cc: Kim Phillips <kim.phillips@freescale.com>
Subject: [PATCH 1/2] net: gianfar - initialize per-queue statistics
Date: Tue, 30 Mar 2010 16:54:21 -0500 [thread overview]
Message-ID: <1269986062-1697-1-git-send-email-kim.phillips@freescale.com> (raw)
Interfaces come up claiming having already received 3.0 GiB.
Use kzalloc to properly initialize per-queue data.
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
drivers/net/gianfar.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index 669de02..d557ab6 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -676,7 +676,7 @@ static int gfar_of_init(struct of_device *ofdev, struct net_device **pdev)
priv->rx_queue[i] = NULL;
for (i = 0; i < priv->num_tx_queues; i++) {
- priv->tx_queue[i] = (struct gfar_priv_tx_q *)kmalloc(
+ priv->tx_queue[i] = (struct gfar_priv_tx_q *)kzalloc(
sizeof (struct gfar_priv_tx_q), GFP_KERNEL);
if (!priv->tx_queue[i]) {
err = -ENOMEM;
@@ -689,7 +689,7 @@ static int gfar_of_init(struct of_device *ofdev, struct net_device **pdev)
}
for (i = 0; i < priv->num_rx_queues; i++) {
- priv->rx_queue[i] = (struct gfar_priv_rx_q *)kmalloc(
+ priv->rx_queue[i] = (struct gfar_priv_rx_q *)kzalloc(
sizeof (struct gfar_priv_rx_q), GFP_KERNEL);
if (!priv->rx_queue[i]) {
err = -ENOMEM;
--
1.7.0.2
next reply other threads:[~2010-03-30 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 21:54 Kim Phillips [this message]
2010-03-30 21:54 ` [PATCH 2/2] net: gianfar - align BD ring size console messages Kim Phillips
2010-03-31 6:09 ` David Miller
2010-03-31 6:09 ` [PATCH 1/2] net: gianfar - initialize per-queue statistics David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269986062-1697-1-git-send-email-kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=Sandeep.Kumar@freescale.com \
--cc=avorontsov@ru.mvista.com \
--cc=davem@davemloft.net \
--cc=galak@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).