* [PATCH 1/2] net: gianfar - initialize per-queue statistics
@ 2010-03-30 21:54 Kim Phillips
2010-03-30 21:54 ` [PATCH 2/2] net: gianfar - align BD ring size console messages Kim Phillips
2010-03-31 6:09 ` [PATCH 1/2] net: gianfar - initialize per-queue statistics David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Kim Phillips @ 2010-03-30 21:54 UTC (permalink / raw)
To: David S. Miller, Anton Vorontsov, Sandeep Gopalpet, Kumar Gala,
Andy
Cc: Kim Phillips
Interfaces come up claiming having already received 3.0 GiB.
Use kzalloc to properly initialize per-queue data.
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
drivers/net/gianfar.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index 669de02..d557ab6 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -676,7 +676,7 @@ static int gfar_of_init(struct of_device *ofdev, struct net_device **pdev)
priv->rx_queue[i] = NULL;
for (i = 0; i < priv->num_tx_queues; i++) {
- priv->tx_queue[i] = (struct gfar_priv_tx_q *)kmalloc(
+ priv->tx_queue[i] = (struct gfar_priv_tx_q *)kzalloc(
sizeof (struct gfar_priv_tx_q), GFP_KERNEL);
if (!priv->tx_queue[i]) {
err = -ENOMEM;
@@ -689,7 +689,7 @@ static int gfar_of_init(struct of_device *ofdev, struct net_device **pdev)
}
for (i = 0; i < priv->num_rx_queues; i++) {
- priv->rx_queue[i] = (struct gfar_priv_rx_q *)kmalloc(
+ priv->rx_queue[i] = (struct gfar_priv_rx_q *)kzalloc(
sizeof (struct gfar_priv_rx_q), GFP_KERNEL);
if (!priv->rx_queue[i]) {
err = -ENOMEM;
--
1.7.0.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] net: gianfar - align BD ring size console messages
2010-03-30 21:54 [PATCH 1/2] net: gianfar - initialize per-queue statistics Kim Phillips
@ 2010-03-30 21:54 ` Kim Phillips
2010-03-31 6:09 ` David Miller
2010-03-31 6:09 ` [PATCH 1/2] net: gianfar - initialize per-queue statistics David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Kim Phillips @ 2010-03-30 21:54 UTC (permalink / raw)
To: David S. Miller, Anton Vorontsov, Sandeep Gopalpet, Kumar Gala,
Andy
Cc: Kim Phillips
fix this:
eth2: :RX BD ring size for Q[0]: 256
eth2:TX BD ring size for Q[0]: 256
to look like:
eth2: RX BD ring size for Q[0]: 256
eth2: TX BD ring size for Q[0]: 256
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
drivers/net/gianfar.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index d557ab6..5131d12 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -1120,10 +1120,10 @@ static int gfar_probe(struct of_device *ofdev,
/* provided which set of benchmarks. */
printk(KERN_INFO "%s: Running with NAPI enabled\n", dev->name);
for (i = 0; i < priv->num_rx_queues; i++)
- printk(KERN_INFO "%s: :RX BD ring size for Q[%d]: %d\n",
+ printk(KERN_INFO "%s: RX BD ring size for Q[%d]: %d\n",
dev->name, i, priv->rx_queue[i]->rx_ring_size);
for(i = 0; i < priv->num_tx_queues; i++)
- printk(KERN_INFO "%s:TX BD ring size for Q[%d]: %d\n",
+ printk(KERN_INFO "%s: TX BD ring size for Q[%d]: %d\n",
dev->name, i, priv->tx_queue[i]->tx_ring_size);
return 0;
--
1.7.0.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] net: gianfar - initialize per-queue statistics
2010-03-30 21:54 [PATCH 1/2] net: gianfar - initialize per-queue statistics Kim Phillips
2010-03-30 21:54 ` [PATCH 2/2] net: gianfar - align BD ring size console messages Kim Phillips
@ 2010-03-31 6:09 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2010-03-31 6:09 UTC (permalink / raw)
To: kim.phillips; +Cc: avorontsov, Sandeep.Kumar, galak, afleming, netdev
From: Kim Phillips <kim.phillips@freescale.com>
Date: Tue, 30 Mar 2010 16:54:21 -0500
> Interfaces come up claiming having already received 3.0 GiB.
> Use kzalloc to properly initialize per-queue data.
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-31 6:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-30 21:54 [PATCH 1/2] net: gianfar - initialize per-queue statistics Kim Phillips
2010-03-30 21:54 ` [PATCH 2/2] net: gianfar - align BD ring size console messages Kim Phillips
2010-03-31 6:09 ` David Miller
2010-03-31 6:09 ` [PATCH 1/2] net: gianfar - initialize per-queue statistics David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).