From: Eric Dumazet <eric.dumazet@gmail.com>
To: Tom Herbert <therbert@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] rfs: Receive Flow Steering
Date: Fri, 02 Apr 2010 14:37:51 +0200 [thread overview]
Message-ID: <1270211871.11099.2.camel@edumazet-laptop> (raw)
In-Reply-To: <1270197304.1936.179.camel@edumazet-laptop>
> > +static inline void rps_record_sock_flow(struct rps_sock_flow_table *table,
> > + u32 hash)
> > +{
>
> Hmm, so rps_record_sock_flow() is always called from non preemptable
> contextes ?
>
> > + rps_set_sock_flow(table, hash, smp_processor_id());
> > +}
> > +
I had to change this to :
static inline void rps_record_sock_flow(struct rps_sock_flow_table *table, u32 hash)
{
/* we only give a hint, preemption can change our cpu under us */
rps_set_sock_flow(table, hash, raw_smp_processor_id());
}
next prev parent reply other threads:[~2010-04-02 12:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 3:59 [PATCH] rfs: Receive Flow Steering Tom Herbert
2010-04-02 5:04 ` Changli Gao
2010-04-02 7:29 ` Eric Dumazet
2010-04-02 10:58 ` Changli Gao
2010-04-02 12:01 ` Eric Dumazet
2010-04-02 13:45 ` Changli Gao
2010-04-02 17:01 ` Rick Jones
[not found] ` <g2i65634d661004021045uff7c0e25ge7dfd17929bc9ee9@mail.gmail.com>
2010-04-02 18:25 ` Rick Jones
2010-04-08 1:37 ` Changli Gao
2010-04-02 7:58 ` Eric Dumazet
2010-04-02 8:35 ` Eric Dumazet
2010-04-02 12:37 ` Eric Dumazet [this message]
2010-04-02 16:28 ` Eric Dumazet
2010-04-02 19:43 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270211871.11099.2.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox